From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753784AbcFHGAA (ORCPT ); Wed, 8 Jun 2016 02:00:00 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:45187 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753124AbcFHF77 (ORCPT ); Wed, 8 Jun 2016 01:59:59 -0400 Date: Tue, 7 Jun 2016 22:59:58 -0700 From: Greg KH To: Rumesh Hapuarachchi Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Staging: unisys: visorhba: visorhba_main: fixed a coding style issue Message-ID: <20160608055958.GA10259@kroah.com> References: <1463770846-24457-1-git-send-email-rehrumesh@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1463770846-24457-1-git-send-email-rehrumesh@gmail.com> User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, May 21, 2016 at 12:30:46AM +0530, Rumesh Hapuarachchi wrote: > fixed checkpatch.pl warning about 'Prefer 'unsigned int' to bare use of 'unsigned' > > Signed-off-by: Rumesh Hapuarahcchi > --- > drivers/staging/unisys/visorhba/visorhba_main.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/unisys/visorhba/visorhba_main.c b/drivers/staging/unisys/visorhba/visorhba_main.c > index 6a4570d..3b69b33 100644 > --- a/drivers/staging/unisys/visorhba/visorhba_main.c > +++ b/drivers/staging/unisys/visorhba/visorhba_main.c > @@ -1122,9 +1122,9 @@ static int visorhba_probe(struct visor_device *dev) > if (err < 0) > goto err_scsi_host_put; > > - scsihost->max_id = (unsigned)max.max_id; > - scsihost->max_lun = (unsigned)max.max_lun; > - scsihost->cmd_per_lun = (unsigned)max.cmd_per_lun; > + scsihost->max_id = (unsigned int)max.max_id; > + scsihost->max_lun = (unsigned int)max.max_lun; > + scsihost->cmd_per_lun = (unsigned int)max.cmd_per_lun; > scsihost->max_sectors = > (unsigned short)(max.max_io_size >> 9); > scsihost->sg_tablesize = Someone else sent this patch for this issue before you did, sorry :(