From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161787AbcFHI2N (ORCPT ); Wed, 8 Jun 2016 04:28:13 -0400 Received: from mail-db3on0100.outbound.protection.outlook.com ([157.55.234.100]:37856 "EHLO emea01-db3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1161190AbcFHI2J (ORCPT ); Wed, 8 Jun 2016 04:28:09 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=idosch@mellanox.com; Date: Wed, 8 Jun 2016 10:53:24 +0300 From: Ido Schimmel To: Bhaktipriya Shridhar CC: Jiri Pirko , Tejun Heo , , Subject: Re: [PATCH] mlxsw: core: Remove deprecated create_workqueue Message-ID: <20160608075324.GA4824@colbert.mtl.com> References: <20160607195946.GA11743@Karyakshetra> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20160607195946.GA11743@Karyakshetra> User-Agent: Mutt/1.5.24 (2015-08-30) X-Originating-IP: [193.47.165.251] X-ClientProxiedBy: AM4PR0501CA0022.eurprd05.prod.outlook.com (10.167.83.160) To HE1PR05MB0988.eurprd05.prod.outlook.com (10.161.115.14) X-MS-Office365-Filtering-Correlation-Id: 9da0882f-65a5-440f-bd95-08d38f72403c X-Microsoft-Exchange-Diagnostics: 1;HE1PR05MB0988;2:Y2ghpBzI87sDUroezHU88UjopSDUCuAqu0EiX/VB4VgA2yFeyBMc0fXkLacMtqifFGQfyLdyUN4z+DtzxK4JUjwG6AZ2VLr/jFz0pgUmS9N3VaLH1yb2yJAe/xmDFaJkOWA3VzH5g9KUTaHI/aatHLw81T3Ki2O3Q9nSGNKs2/QzKAiLiSE8ekfweNHKyBPG;3:UjWTKK4wTt0bv0tjVjkXZ8U7M495vAQe6IBSyGTUyvS3kAZlyu837TSX1ZxZ7g4Mbve5IjiQDm2h3xwIg1Ggd5f8qIOqqdGrejqQsZAHhRyIbbKGB5TEYdpUNZbw4iSP;25:vLAY4iPFY6S6ac5GOIgI3COQ2Yf61xam4Y/k/r8g4T/uf/m09gr9wBoDONhy7mbIXeAQEYHv+pNyvii55DLbdimn8YuBcoiDN7QC19mwcwUo9YNN9t+FWnj+f7iAZRN6uTSKFVVcA2SPUvGRckEe/rt0n8cvHjmnxZsOZiycl/LYGkfh+m5z86JiypAge3oJdr6soVd3xd2+BOv5FKLeD56SJR1dvz9U1a5xQBmy2fAsk4WjK5AhxFwVKrOGnQAVbl/GkYKn/215Pi6L6V35rb9hIb7a8oiIDKsL9ZDGsKu4AL185r13WLKVf904fUWfYLHQDDFUNnPA9U8ytait4egcGlETMYNVy4vfnqYIdr7DoXUA6ofhCEVA4WXOwymjYFoOKmKdwu0cNPFA8h5O/U1A0wGeAGRytuLFTGtY+bc= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:HE1PR05MB0988; X-Microsoft-Exchange-Diagnostics: 1;HE1PR05MB0988;20:PsnFpYQKDZkLT72fTMJ1PGVQwLWyWsZSwuRlz81b/WJW0YzIsjD0MufgrlVztp53CbhG/jXl1BbMO5qRKsBlPQm6UWa4RlVZFsErg8iNAa0ytydeW1lWhybsWZcWtG532LLiK/98kkZUtMqE4qyjhHrQUqKwgGRpqiGgsEFD+N1jfmhaIEpnm2npG0b0FSGm6UulVyjbC0JU15ga3fedVFOFc1sO5zPt78BJzY+JWUvA1ddv87SWKZT22Sr80RQpfsPwAno9Upec2sJcLuIj+5sqmSw9SVqxBMt1XdxTlVrVH3dI1IXIr29ez81rol4LwIF7xG3Vn4qbjwD/Uw8rKjkdXuXoYLMgxb1BQnfH5uJ24iCFpaWhnGlgfbVBuNqiFZE8gAJmkhmpk8Kiw9sPhmkKNdQOqu50LdSsR01gHFy7ubSi6b1hyfcaPfXPQIGQnijnlVmsEyD5IEzO1BoWdBBANKt9odHGTz3RFs0IqmKaIBZ/fK7p+TRSL8ctEp0N;4:zEtMUP+l1awhHKvUgK/ZFLdOpxx9EGGWxLBGAJuT/5o1TvFV8M1xB3qOpeIDCdaiwuKxmtCMzdyQwsRnILk/b0KT6EllD8uhjEf0u/D3SzjP7nfy+YX+KLzqe79u6wBvTbCqE0A+DqvZRM//jj0ijNAh3v+BHzwmUV4qBho80NVTsbGv269hCv4ATjSfEoxtz2TOl7xrtvWv9ODYX3p7iQLETNGYpVEHIxEHjvhi04Yc8+ib5q2nVXyMR2PQxivOo9XPCbKsK3q6ijyJtujiTOn1uMtdIMLICMCnsLlpbKL29R73YQhBR7tVApydUBjPISTncACSPzt+82dvJ6yY+gl/jzvT4hTASRr1IOsFZpp3SkRKHKz0Cz9UysbSv9azhPFGAn61RjzujPyyuJ/hBg== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6055026);SRVR:HE1PR05MB0988;BCL:0;PCL:0;RULEID:;SRVR:HE1PR05MB0988; X-Forefront-PRVS: 0967749BC1 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6069001)(6009001)(189002)(199003)(24454002)(3846002)(1411001)(586003)(23726003)(6116002)(50466002)(97756001)(77096005)(1076002)(106356001)(105586002)(5004730100002)(81166006)(4001350100001)(81156014)(97736004)(189998001)(86362001)(110136002)(47776003)(8676002)(66066001)(5008740100001)(92566002)(19580405001)(42186005)(19580395003)(2906002)(76176999)(54356999)(50986999)(2950100001)(76506005)(83506001)(33656002)(46406003)(4326007)(101416001)(9686002)(68736007)(87944003);DIR:OUT;SFP:1101;SCL:1;SRVR:HE1PR05MB0988;H:localhost;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;HE1PR05MB0988;23:kN+G6069Oxhr4VGugWeRFOIENyMyqClIUl97RJw63?= =?us-ascii?Q?kegZuPP2sM4vTyGYLByXQ0GysWzoVNG4x8E03xGGoZMr8B1DZENv6ehmmQSm?= =?us-ascii?Q?MhFaNCAYkkoMzjuxZ47ep54h/+8q5EaJhqRvL6pn7ogyMZLkunNbMLljR2TT?= =?us-ascii?Q?4xSY0oZEL03+gtVeMkPvzQ6VvTvY+99ZtTyveQxSzUWMZJ+cPRHiG+BpMHqq?= =?us-ascii?Q?8Uz42KDbzFwwzFj/lyEqIbL3lWrcRnFG0cIL1zLd5B99DKP7pJY4yu5ot/Nx?= =?us-ascii?Q?xNh8CefKbEhssJ+Mwd/1koonoOokcCczAfti+5wa46/qnbPs01OE0z0/Zptm?= =?us-ascii?Q?KG0W2qWG+CMdkBY93Y37C9wAbY+Ggg+Og9PNd5mMGe9Blq+q3bczk8S7CH2n?= =?us-ascii?Q?nPFCzKhwEvZnaaV68XmEn4tNBRv4QFohLtuWbqp0qiROHjPR1EgaaABI9iBH?= =?us-ascii?Q?V66LNd8gnXul7t+/QexSXAZCv4qwtTC3/tmJekpWdgz5gmQPJqgRLDjqZY9S?= =?us-ascii?Q?rbbZSVifE8wNILa6eziH7QYYT8empoPKpgaxjncCMq+v0ztXzhFUV7N9DiaO?= =?us-ascii?Q?8xrr6CPCFmqCrzzZpDAh5uI3ZdLuMLPknUFh5+lKXsJjiC0ADuOSbkIjJ7AV?= =?us-ascii?Q?AJNPALx1LcYEgxQhuH4MwO/XffkN8gvWmw2KLKsPrazxUa1epTlD5ph3u2b8?= =?us-ascii?Q?XWjNn7uH8qYT4Ln0QUi+9hvc9mT0yOtgI7gZNkT1fU5HX/DuY61nOslHY8If?= =?us-ascii?Q?/9da9c0ha4YYPHA7RKzJrI4fCk9hCnWqcHylAQHzpMvM7Wz0gSCFFLiHOfw9?= =?us-ascii?Q?W98tUEqhDfLZRwXLHVfm/mk0KM6FEOgDK0gL8uGPF9xaill7mITb0bRKOBzK?= =?us-ascii?Q?hNJVL783nVes4P9nxWHCD32y2b5FgYvjnLppD8dcL7wh4nOWlpL1UPJvxwn6?= =?us-ascii?Q?erqbgpPJmDypubyOsYJHpKPnfId89slPQFWK9lKLoxI9OAfX3NSE0KrlX5tu?= =?us-ascii?Q?DFw9/P8tqgpAWZIiDnn7FJKeXCidYtQb50LYuu6wfjcsJaJbjmHEXSJOaDRn?= =?us-ascii?Q?RohXqlfa4OEya7RU8C1H+b8DJsJ8KCe2hdVnKSi4KfUYNb/CnMzi8DGat0xH?= =?us-ascii?Q?1QS3wL/q18B7VL8SaxwafvZHUVedSSJsEXL/U7iG8CKjzlw0W7DsA3+h2+Kb?= =?us-ascii?Q?C1+hqoPfS/N9qE=3D?= X-Microsoft-Exchange-Diagnostics: 1;HE1PR05MB0988;5:lT7W1EYUzQrWzcJjg+jqwCDatJEnOeD1uQ6SgvDGEB6lV90af3f2LHGzho0Q8kxS/b7HnBJ1ZDjmvmx0/ODOKrq/8WdLIK7RyBEuK6wc2CfVcPxga6FnGFsT/NFC7o23wnKvYZHhk/+Sn8jfMEKeNw==;24:2FoTThVcXh2ZNIOIqLYKNW/aCPuTZHjdLDaTRwFJfeonKUDoVzUfwMBDmou4fVTjLA0IySWc4HvOKMlqD91FUcnC7r1zNvVGmUuNIwCeqjQ=;7:S+g0AiHwH8wocTCEnadMKaPCDCbbhWQEX8Jz9UaOp/SmTMX/IOX/ZQOZ1UJz3oWRT+0Ss3RMccxeem5WKIviLcqVupy+ENJIhVvhEjdJZm/PErfQhFbQJIKrB6fwYV1KSb+BBq2vRKNHNSKaB+0DoZHif9+/WthzV2sUrqRlgV0vmAeXz1U4dUQkMDnsK82ur2TSnutwH1xCP8ynAMcVrX7+LBxTxcGOc8uYTOl2Hls= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jun 2016 07:55:25.3481 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR05MB0988 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Tue, Jun 07, 2016 at 10:59:46PM IDT, bhaktipriya96@gmail.com wrote: >alloc_workqueue replaces deprecated create_workqueue(). > >A dedicated workqueue has been used since the workqueue >mlxsw_wq is used for FDB notif. processing with workitems that are >involved in normal device operation && because it's a network device >which can be depended upon during memory reclaim. > >Workitems &trans->timeout_dw and &mlxsw_sp->fdb_notify.dw, >map to mlxsw_sp_fdb_notify_work (processes FDB notifications from the >underlying device and resolves the netdev to which the entry points to >and notifies the bridge using the switchdev notifier) and >mlxsw_emad_trans_timeout_work (provides async EMAD register access) >respectively. The ordering here is off - timeout_dw is for mlxsw_emad_trans_timeout_work() and fdb_notify.dw is for mlxsw_sp_fdb_notify_work(), but otherwise this seems fine to me. Tested-by: Ido Schimmel Thanks!