From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932935AbcFHNlZ (ORCPT <rfc822;w@1wt.eu>);
	Wed, 8 Jun 2016 09:41:25 -0400
Received: from mail-pa0-f50.google.com ([209.85.220.50]:33994 "EHLO
	mail-pa0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751949AbcFHNlX (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 8 Jun 2016 09:41:23 -0400
Date: Wed, 8 Jun 2016 09:41:14 -0400
From: Jarod Wilson <jarod@redhat.com>
To: Bert Kenward <bkenward@solarflare.com>
Cc: linux-kernel@vger.kernel.org,
        Solarflare linux maintainers <linux-net-drivers@solarflare.com>,
        Edward Cree <ecree@solarflare.com>, David Miller <davem@davemloft.net>,
        netdev@vger.kernel.org
Subject: Re: [PATCH net v2] sfc: report supported link speeds on SFP
 connections
Message-ID: <20160608134114.GJ56933@redhat.com>
References: <1464917604-11596-1-git-send-email-jarod@redhat.com>
 <a354e801-dc3e-bae4-0dcb-f174df8b9161@solarflare.com>
 <20160606185529.GV56933@redhat.com>
 <20160607212016.GH56933@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160607212016.GH56933@redhat.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jun 07, 2016 at 05:20:16PM -0400, Jarod Wilson wrote:
> On Mon, Jun 06, 2016 at 02:55:29PM -0400, Jarod Wilson wrote:
> > On Mon, Jun 06, 2016 at 05:29:30PM +0100, Bert Kenward wrote:
> > > 7000-series SFC NICs connected with an SFP+ module currently fail to
> > > report any supported link speeds.
> > > 
> > > Reported-by: Jarod Wilson <jarod@redhat.com>
> > > Signed-off-by: Bert Kenward <bkenward@solarflare.com>
> > 
> > Had a feeling my cut might not have been quite right. Looks good to me.
> > 
> > Reviewed-by: Jarod Wilson <jarod@redhat.com>
> 
> ...however, upon testing, there's a gotcha. This results in my 10Gbps sfc
> nic reporting that it supports 40Gbps:
> 
> $ ethtool ens4f0
> Settings for ens4f0:
> 	Supported ports: [ FIBRE ]
> 	Supported link modes:   1000baseT/Full
> 	                        10000baseT/Full
> 	                        40000baseKR4/Full

This turned out to be a flub on my part. My local tree wasn't clean, had
some lingering test/debug crap in it that I thought I'd removed, but
clearly, hadn't. With that removed, we're all good here.

Tested-by: Jarod Wilson <jarod@redhat.com>

-- 
Jarod Wilson
jarod@redhat.com