From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1425620AbcFHNq0 (ORCPT ); Wed, 8 Jun 2016 09:46:26 -0400 Received: from mail-wm0-f41.google.com ([74.125.82.41]:37788 "EHLO mail-wm0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753727AbcFHNqZ (ORCPT ); Wed, 8 Jun 2016 09:46:25 -0400 Date: Wed, 8 Jun 2016 15:46:20 +0200 From: Ingo Molnar To: Paolo Bonzini Cc: Andy Lutomirski , Thomas Gleixner , linux-kernel@vger.kernel.org, Ingo Molnar , "H. Peter Anvin" , X86 ML , Rik van Riel , Peter Zijlstra Subject: Re: [PATCH 1/2] x86/entry: Avoid interrupt flag save and restore Message-ID: <20160608134620.GA21374@gmail.com> References: <1464611414-12379-1-git-send-email-pbonzini@redhat.com> <1464611414-12379-2-git-send-email-pbonzini@redhat.com> <0e02e304-a226-a35c-1109-25a35d4eae67@redhat.com> <20160608121655.GA11355@gmail.com> <2bce50fc-3cf0-eeec-1ea7-4d54550b774a@redhat.com> <20160608125406.GA11563@gmail.com> <1855965895.20836430.1465393198716.JavaMail.zimbra@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1855965895.20836430.1465393198716.JavaMail.zimbra@redhat.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Paolo Bonzini wrote: > > So I believe it would be cleaner to name the irqs-off code paths explicitly: > > __guest_enter_irqsoff(), and propagate that naming into other parts as well? > > Ok, I'll send v2 with both the KVM cleanups and the entry optimizations. It should > be four patches putting all things together. Thanks for the review! Sounds good to me, thanks! Ingo