From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1425972AbcFHTwY (ORCPT ); Wed, 8 Jun 2016 15:52:24 -0400 Received: from mail-oi0-f68.google.com ([209.85.218.68]:35758 "EHLO mail-oi0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1424668AbcFHTwD (ORCPT ); Wed, 8 Jun 2016 15:52:03 -0400 Date: Wed, 8 Jun 2016 14:52:01 -0500 From: Rob Herring To: thloh@altera.com Cc: pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, peppe.cavallaro@st.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH v3 1/1] net: ethernet: Add TSE PCS support to dwmac-socfpga Message-ID: <20160608195201.GA5838@rob-hp-laptop> References: <1465268516-31480-1-git-send-email-thloh@altera.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1465268516-31480-1-git-send-email-thloh@altera.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 06, 2016 at 08:01:56PM -0700, thloh@altera.com wrote: > From: Tien Hock Loh > > This adds support for TSE PCS that uses SGMII adapter when the phy-mode of > the dwmac is set to sgmii > > Signed-off-by: Tien Hock Loh > > --- > v2: > - Refactored the TSE PCS out from the dwmac-socfpga.c file > - Added binding documentation for TSE PCS sgmii adapter > v3: > - Added missing license header for new source files > - Updated tse_pcs.h include headers > - Standardize if statements > --- > .../devicetree/bindings/net/socfpga-dwmac.txt | 4 + > drivers/net/ethernet/stmicro/stmmac/Makefile | 2 +- > .../net/ethernet/stmicro/stmmac/dwmac-socfpga.c | 140 +++++++++-- > drivers/net/ethernet/stmicro/stmmac/tse_pcs.c | 261 +++++++++++++++++++++ > drivers/net/ethernet/stmicro/stmmac/tse_pcs.h | 36 +++ > 5 files changed, 419 insertions(+), 24 deletions(-) > create mode 100644 drivers/net/ethernet/stmicro/stmmac/tse_pcs.c > create mode 100644 drivers/net/ethernet/stmicro/stmmac/tse_pcs.h > > diff --git a/Documentation/devicetree/bindings/net/socfpga-dwmac.txt b/Documentation/devicetree/bindings/net/socfpga-dwmac.txt > index 3a9d679..2bc39f1 100644 > --- a/Documentation/devicetree/bindings/net/socfpga-dwmac.txt > +++ b/Documentation/devicetree/bindings/net/socfpga-dwmac.txt > @@ -15,6 +15,8 @@ Required properties: > Optional properties: > altr,emac-splitter: Should be the phandle to the emac splitter soft IP node if > DWMAC controller is connected emac splitter. > +phy-mode: The phy mode the ethernet operates in > +altr,sgmii_to_sgmii_converter: phandle to the TSE SGMII converter Use '-' rather than '_'. With that, for the binding: Acked-by: Rob Herring