From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933411AbcFHUAn (ORCPT ); Wed, 8 Jun 2016 16:00:43 -0400 Received: from mail-pf0-f176.google.com ([209.85.192.176]:34597 "EHLO mail-pf0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752271AbcFHUAm (ORCPT ); Wed, 8 Jun 2016 16:00:42 -0400 Date: Wed, 8 Jun 2016 13:00:38 -0700 From: Brian Norris To: Srinivas Kandagatla Cc: Maxime Ripard , linux-kernel@vger.kernel.org, Brian Norris , Greg Kroah-Hartman , Guenter Roeck Subject: Re: [PATCH] nvmem: fix nvmem_cell_read() return type for !CONFIG_NVMEM Message-ID: <20160608200038.GA136963@google.com> References: <1465403206-142082-1-git-send-email-briannorris@chromium.org> <20160608164011.GA144473@google.com> <57586956.2070008@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <57586956.2070008@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 08, 2016 at 07:52:06PM +0100, Srinivas Kandagatla wrote: > On 08/06/16 17:40, Brian Norris wrote: > >On Wed, Jun 08, 2016 at 09:26:46AM -0700, Brian Norris wrote: > >>With CONFIG_NVMEM, nvmem_cell_read() returns void *. With !CONFIG_NVMEM > >>it returns char *. Let's make that consistent. Also drop the > >>incorrect/inconsistent comment about char * above the nvmem_cell_read() > >>definition. > >> > >>drivers/thermal/mtk_thermal.c is already working around this by casting > >>to (u32 *). > >> > >>Signed-off-by: Brian Norris > > > >Seems Guenter submitted the same thing a week ago, with no response: > > This patch has been already sent to Greg few days back with my sign > off http://permalink.gmane.org/gmane.linux.kernel/2233276 Ah, didn't notice that either. Anyway, doesn't seem to show up in linux-next. Brian