From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1424986AbcFHT5c (ORCPT ); Wed, 8 Jun 2016 15:57:32 -0400 Received: from mail-wm0-f51.google.com ([74.125.82.51]:37389 "EHLO mail-wm0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752271AbcFHT5a (ORCPT ); Wed, 8 Jun 2016 15:57:30 -0400 From: Pali =?utf-8?q?Roh=C3=A1r?= To: Darren Hart Subject: Re: [PATCH 2/4] dell-wmi: Sort WMI event codes and update comments Date: Wed, 8 Jun 2016 21:57:26 +0200 User-Agent: KMail/1.13.7 (Linux/3.13.0-86-generic; KDE/4.14.2; x86_64; ; ) Cc: =?utf-8?q?Micha=C5=82_K=C4=99pie=C5=84?= , Matthew Garrett , Gabriele Mazzotta , Mario Limonciello , Andy Lutomirski , Alex Hung , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org References: <1463916983-12562-1-git-send-email-pali.rohar@gmail.com> <20160607220324.GN29844@pali> <20160608194824.GC28348@f23x64.localdomain> In-Reply-To: <20160608194824.GC28348@f23x64.localdomain> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart1522957.ofMWncLNHm"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201606082157.26447@pali> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --nextPart1522957.ofMWncLNHm Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Wednesday 08 June 2016 21:48:24 Darren Hart wrote: > On Wed, Jun 08, 2016 at 12:03:24AM +0200, Pali Roh=C3=A1r wrote: > > On Thursday 02 June 2016 12:41:42 Micha=C5=82 K=C4=99pie=C5=84 wrote: > > > > Signed-off-by: Pali Roh=C3=A1r > > >=20 > > > My guess is that Darren won't let you off without at least a > > > short commit message. > >=20 > > I have no idea what else to write. I think that description is > > enough. >=20 > There is always something. For example, why? See > Documentation/SubmittingPatches section "14) The canonical patch > format" for an explanation. >=20 > "Traceability" of changes is important. If it's worth preparing the > patch, it's worth documenting why. In my opinion current description is enough and cover everything what=20 this patch is doing. I think it is clear from my description what this=20 patch is doing and so it is documented. But if it is not clear and something is missing, let me know or show=20 what is wrong and how you change it... It is just my assumption that=20 "Sort WMI event codes and update comments" is clear... =2D-=20 Pali Roh=C3=A1r pali.rohar@gmail.com --nextPart1522957.ofMWncLNHm Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEYEABECAAYFAldYeKYACgkQi/DJPQPkQ1L7qwCghvH9C7WOX7wZ8Mzz0X+y2Yq7 kAgAn2kOyUAn7bFxC4ehRDDjtbRwdkzA =CwF7 -----END PGP SIGNATURE----- --nextPart1522957.ofMWncLNHm--