From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1425871AbcFICad (ORCPT ); Wed, 8 Jun 2016 22:30:33 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:39448 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161396AbcFICac (ORCPT ); Wed, 8 Jun 2016 22:30:32 -0400 Date: Thu, 9 Jun 2016 04:30:29 +0200 From: Andrew Lunn To: Vivien Didelot Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, "David S. Miller" , Florian Fainelli Subject: Re: [PATCH net-next 2/8] net: dsa: mv88e6xxx: remove redundant assignments Message-ID: <20160609023029.GH2227@lunn.ch> References: <20160609004456.5441-1-vivien.didelot@savoirfairelinux.com> <20160609004456.5441-3-vivien.didelot@savoirfairelinux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160609004456.5441-3-vivien.didelot@savoirfairelinux.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 08, 2016 at 08:44:50PM -0400, Vivien Didelot wrote: > The chip->ds and ds->slave_mii_bus assignments are common to both legacy > and new MDIO probing and are already done in the later setup code. > > Remove the duplicated assignments from the MDIO probing code. > > Signed-off-by: Vivien Didelot Reviewed-by: Andrew Lunn Andrew