From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1426474AbcFICjj (ORCPT ); Wed, 8 Jun 2016 22:39:39 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:39466 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1426351AbcFICjh (ORCPT ); Wed, 8 Jun 2016 22:39:37 -0400 Date: Thu, 9 Jun 2016 04:39:34 +0200 From: Andrew Lunn To: Vivien Didelot Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, "David S. Miller" , Florian Fainelli Subject: Re: [PATCH net-next 5/8] net: dsa: mv88e6xxx: add switch register helpers Message-ID: <20160609023934.GK2227@lunn.ch> References: <20160609004456.5441-1-vivien.didelot@savoirfairelinux.com> <20160609004456.5441-6-vivien.didelot@savoirfairelinux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160609004456.5441-6-vivien.didelot@savoirfairelinux.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 08, 2016 at 08:44:53PM -0400, Vivien Didelot wrote: > Extract the allocation and registration code related to the dsa_switch > structure in a mv88e6xxx_register_switch helper function. > > For symmetry in the code, add a mv88e6xxx_unregister_switch function. You say what you are doing, but not why? Andrew