From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934131AbcFIGsN (ORCPT ); Thu, 9 Jun 2016 02:48:13 -0400 Received: from mail-wm0-f51.google.com ([74.125.82.51]:34044 "EHLO mail-wm0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933293AbcFIGsJ (ORCPT ); Thu, 9 Jun 2016 02:48:09 -0400 Date: Thu, 9 Jun 2016 08:48:03 +0200 From: Ingo Molnar To: Lukas Wunner Cc: Yinghai Lu , Thomas Gleixner , cmilsted@redhat.com, Rafa?? Mi??ecki , Bjorn Helgaas , "H. Peter Anvin" , Matt Fleming , Peter Zijlstra , Linux Kernel Mailing List , Linus Torvalds , Matthew Garrett , m@bues.ch, "linux-tip-commits@vger.kernel.org" Subject: Re: [tip:x86/urgent] x86/quirks: Add early quirk to reset Apple AirPort card Message-ID: <20160609064803.GA10996@gmail.com> References: <82c2548dffc6cfbc484b9111b1073f407c946061.1464477483.git.lukas@wunner.de> <20160608200929.GA18981@wunner.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160608200929.GA18981@wunner.de> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Lukas Wunner wrote: > > How do you know that sec is valid ? > > > > How about on the system that have one bridge that still have sec num register 0? > > > > it will be get into dead loop. > > Good point. I've just checked pci_scan_bridge() and it does verify that and > avoids recursing to a child bus if it's number is zero. It also ensures that sec > > num before recursing. > > I can provide a follow-up patch to fix that, will wait a bit though to see if > there are further comments. Please send a delta fix on top of x86/urgent. (I'll probably squash the two fixes together.) Thanks, Ingo