From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751565AbcFIMYO (ORCPT ); Thu, 9 Jun 2016 08:24:14 -0400 Received: from merlin.infradead.org ([205.233.59.134]:59282 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751268AbcFIMYL (ORCPT ); Thu, 9 Jun 2016 08:24:11 -0400 Date: Thu, 9 Jun 2016 14:24:04 +0200 From: Peter Zijlstra To: Minfei Huang Cc: bp@suse.de, pbonzini@redhat.com, luto@kernel.org, hpa@zytor.com, mingo@redhat.com, tglx@linutronix.de, x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3 V2] pvclock: Get rid of __pvclock_read_cycles in function pvclock_read_flags Message-ID: <20160609122404.GB30927@twins.programming.kicks-ass.net> References: <1464329832-4638-3-git-send-email-mnghuan@gmail.com> <1464438463-8485-1-git-send-email-mnghuan@gmail.com> <20160609121603.GB30935@twins.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160609121603.GB30935@twins.programming.kicks-ass.net> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 09, 2016 at 02:16:03PM +0200, Peter Zijlstra wrote: > What's wrong with: > > u8 flags = READ_ONCE(src->flags); > > ? > > (and have the flags store be done using WRITE_ONCE() of course). > > Sure, if your total state is larger than one word you need the > seqcount for integrity, but reading _one_ byte, shees. Something like so; although given that I've never seen this code before I can easily have missed an update site. diff --git a/arch/x86/kernel/pvclock.c b/arch/x86/kernel/pvclock.c index 99bfc025111d..7a4bf59aa929 100644 --- a/arch/x86/kernel/pvclock.c +++ b/arch/x86/kernel/pvclock.c @@ -60,15 +60,7 @@ void pvclock_resume(void) u8 pvclock_read_flags(struct pvclock_vcpu_time_info *src) { - unsigned version; - cycle_t ret; - u8 flags; - - do { - version = __pvclock_read_cycles(src, &ret, &flags); - } while ((src->version & 1) || version != src->version); - - return flags & valid_flags; + return READ_ONCE(src->flags) & valid_flags; } cycle_t pvclock_clocksource_read(struct pvclock_vcpu_time_info *src) @@ -83,7 +75,8 @@ cycle_t pvclock_clocksource_read(struct pvclock_vcpu_time_info *src) } while ((src->version & 1) || version != src->version); if (unlikely((flags & PVCLOCK_GUEST_STOPPED) != 0)) { - src->flags &= ~PVCLOCK_GUEST_STOPPED; + flags &= ~PVCLOCK_GUEST_STOPPED; + WRITE_ONCE(src->flags, flags); pvclock_touch_watchdogs(); } diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index 1ba3b7d3cae9..54458acce4f5 100644 --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c @@ -1832,7 +1832,7 @@ static int kvm_guest_time_update(struct kvm_vcpu *v) if (use_master_clock) pvclock_flags |= PVCLOCK_TSC_STABLE_BIT; - vcpu->hv_clock.flags = pvclock_flags; + WRITE_ONCE(vcpu->hv_clock.flags, pvclock_flags); trace_kvm_pvclock_update(v->vcpu_id, &vcpu->hv_clock);