From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Taeung Song <treeze.taeung@gmail.com>
Cc: linux-kernel@vger.kernel.org, Jiri Olsa <jolsa@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Masami Hiramatsu <mhiramat@kernel.org>,
Wang Nan <wangnan0@huawei.com>, Jiri Olsa <jolsa@redhat.com>
Subject: Re: [PATCH v8 2/5] perf config: Bring declarations about config from util/cache.h to util/config.h
Date: Thu, 9 Jun 2016 10:29:57 -0300 [thread overview]
Message-ID: <20160609132957.GI11589@kernel.org> (raw)
In-Reply-To: <1465389413-8936-3-git-send-email-treeze.taeung@gmail.com>
Em Wed, Jun 08, 2016 at 09:36:50PM +0900, Taeung Song escreveu:
> Lately util/config.h has been added
> but util/cache.h has declarations of functions
> and extern variable for config features.
>
> To manage codes about configuration at one spot, move them
> to util/config.h and util/cache.h include util/config.h
>
> Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
> Cc: Jiri Olsa <jolsa@redhat.com>
> Cc: Masami Hiramatsu <mhiramat@kernel.org>
> Cc: Namhyung Kim <namhyung@kernel.org>
> Cc: Wang Nan <wangnan0@huawei.com>
> Signed-off-by: Taeung Song <treeze.taeung@gmail.com>
> ---
> tools/perf/util/cache.h | 13 +------------
> tools/perf/util/config.h | 12 ++++++++++++
> 2 files changed, 13 insertions(+), 12 deletions(-)
>
> diff --git a/tools/perf/util/cache.h b/tools/perf/util/cache.h
> index 0d814bb..cd8cd4d 100644
> --- a/tools/perf/util/cache.h
> +++ b/tools/perf/util/cache.h
> @@ -7,6 +7,7 @@
> #include <subcmd/pager.h>
> #include "../perf.h"
> #include "../ui/ui.h"
> +#include "config.h"
Why have you added that? Are those config functions used in cache.h?
- Arnaldo
next prev parent reply other threads:[~2016-06-09 13:31 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-08 12:36 [RFC][PATCH v8 0/5] perf config: Reimplement perf_config() using perf_config_set__inter() Taeung Song
2016-06-08 12:36 ` [BUGFIX][PATCH v8 1/5] perf config: Handle the error about NULL at perf_config_set__delete() Taeung Song
2016-06-16 8:31 ` [tip:perf/core] perf config: Handle " tip-bot for Taeung Song
2016-06-08 12:36 ` [PATCH v8 2/5] perf config: Bring declarations about config from util/cache.h to util/config.h Taeung Song
2016-06-09 13:29 ` Arnaldo Carvalho de Melo [this message]
2016-06-10 6:20 ` Taeung Song
2016-06-10 19:06 ` Arnaldo Carvalho de Melo
2016-06-11 0:59 ` Taeung Song
2016-06-12 6:28 ` Taeung Song
2016-06-08 12:36 ` [PATCH v8 3/5] perf config: Reimplement perf_config() using perf_config_set__iter() Taeung Song
2016-06-09 13:34 ` Arnaldo Carvalho de Melo
2016-06-10 10:58 ` Taeung Song
2016-06-12 8:57 ` Taeung Song
2016-06-20 10:00 ` [PATCH v8 3/5] perf config: Reimplement perf_config() using perf_config_set__it to Taeung Song
2016-06-09 13:41 ` [PATCH v8 3/5] perf config: Reimplement perf_config() using perf_config_set__iter() Arnaldo Carvalho de Melo
2016-06-10 11:05 ` Taeung Song
2016-06-08 12:36 ` [PATCH v8 4/5] perf config: Use zfree() instead of free() at perf_config_set__delete() Taeung Song
2016-06-09 13:37 ` Arnaldo Carvalho de Melo
2016-06-10 11:03 ` Taeung Song
2016-06-08 12:36 ` [PATCH v8 5/5] perf config: Reimplement show_config() using perf_config_set__iter() Taeung Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160609132957.GI11589@kernel.org \
--to=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=treeze.taeung@gmail.com \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).