From: Lee Jones <lee.jones@linaro.org>
To: "Andrew F. Davis" <afd@ti.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 5/5] mfd: ti_am335x_tscadc: use variable name for sizeof() operator
Date: Thu, 9 Jun 2016 15:49:14 +0100 [thread overview]
Message-ID: <20160609144914.GL2385@dell> (raw)
In-Reply-To: <20160608155436.30450-6-afd@ti.com>
On Wed, 08 Jun 2016, Andrew F. Davis wrote:
> Fix the code formatting to use the kernel preferred style
> of using the actual variables to determine the size using
> the sizeof() operator.
>
> Signed-off-by: Andrew F. Davis <afd@ti.com>
> Acked-by: Lee Jones <lee.jones@linaro.org>
> ---
> drivers/mfd/ti_am335x_tscadc.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Applied, thanks.
> diff --git a/drivers/mfd/ti_am335x_tscadc.c b/drivers/mfd/ti_am335x_tscadc.c
> index d30bea5..c8f027b 100644
> --- a/drivers/mfd/ti_am335x_tscadc.c
> +++ b/drivers/mfd/ti_am335x_tscadc.c
> @@ -168,8 +168,7 @@ static int ti_tscadc_probe(struct platform_device *pdev)
> }
>
> /* Allocate memory for device */
> - tscadc = devm_kzalloc(&pdev->dev,
> - sizeof(struct ti_tscadc_dev), GFP_KERNEL);
> + tscadc = devm_kzalloc(&pdev->dev, sizeof(*tscadc), GFP_KERNEL);
> if (!tscadc) {
> dev_err(&pdev->dev, "failed to allocate memory.\n");
> return -ENOMEM;
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2016-06-09 14:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-08 15:54 [PATCH v2 0/5] TI AM335x TSC/ADC cleanup Andrew F. Davis
2016-06-08 15:54 ` [PATCH v2 1/5] mfd: ti_am335x_tscadc: Use SIMPLE_DEV_PM_OPS helper macro Andrew F. Davis
2016-06-09 14:48 ` Lee Jones
2016-06-08 15:54 ` [PATCH v2 2/5] mfd: ti_am335x_tscadc: Remove use of single line functions Andrew F. Davis
2016-06-09 14:48 ` Lee Jones
2016-06-08 15:54 ` [PATCH v2 3/5] mfd: ti_am335x_tscadc: Unify variable naming when referencing ti_tscadc_dev Andrew F. Davis
2016-06-09 14:48 ` Lee Jones
2016-06-08 15:54 ` [PATCH v2 4/5] mfd: ti_am335x_tscadc: Rename regmap_tscadc to regmap Andrew F. Davis
2016-06-09 14:49 ` Lee Jones
2016-06-08 15:54 ` [PATCH v2 5/5] mfd: ti_am335x_tscadc: use variable name for sizeof() operator Andrew F. Davis
2016-06-09 14:49 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160609144914.GL2385@dell \
--to=lee.jones@linaro.org \
--cc=afd@ti.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).