From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932514AbcFIOsr (ORCPT ); Thu, 9 Jun 2016 10:48:47 -0400 Received: from mail-wm0-f52.google.com ([74.125.82.52]:37161 "EHLO mail-wm0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752146AbcFIOsp (ORCPT ); Thu, 9 Jun 2016 10:48:45 -0400 Date: Thu, 9 Jun 2016 15:49:14 +0100 From: Lee Jones To: "Andrew F. Davis" Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 5/5] mfd: ti_am335x_tscadc: use variable name for sizeof() operator Message-ID: <20160609144914.GL2385@dell> References: <20160608155436.30450-1-afd@ti.com> <20160608155436.30450-6-afd@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20160608155436.30450-6-afd@ti.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 08 Jun 2016, Andrew F. Davis wrote: > Fix the code formatting to use the kernel preferred style > of using the actual variables to determine the size using > the sizeof() operator. > > Signed-off-by: Andrew F. Davis > Acked-by: Lee Jones > --- > drivers/mfd/ti_am335x_tscadc.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Applied, thanks. > diff --git a/drivers/mfd/ti_am335x_tscadc.c b/drivers/mfd/ti_am335x_tscadc.c > index d30bea5..c8f027b 100644 > --- a/drivers/mfd/ti_am335x_tscadc.c > +++ b/drivers/mfd/ti_am335x_tscadc.c > @@ -168,8 +168,7 @@ static int ti_tscadc_probe(struct platform_device *pdev) > } > > /* Allocate memory for device */ > - tscadc = devm_kzalloc(&pdev->dev, > - sizeof(struct ti_tscadc_dev), GFP_KERNEL); > + tscadc = devm_kzalloc(&pdev->dev, sizeof(*tscadc), GFP_KERNEL); > if (!tscadc) { > dev_err(&pdev->dev, "failed to allocate memory.\n"); > return -ENOMEM; -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog