From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932704AbcFIP2W (ORCPT ); Thu, 9 Jun 2016 11:28:22 -0400 Received: from mail-wm0-f42.google.com ([74.125.82.42]:36949 "EHLO mail-wm0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751864AbcFIP2S (ORCPT ); Thu, 9 Jun 2016 11:28:18 -0400 Date: Thu, 9 Jun 2016 16:28:52 +0100 From: Lee Jones To: Wadim Egorov Cc: linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, rtc-linux@googlegroups.com, devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, mturquette@baylibre.com, sboyd@codeaurora.org, lgirdwood@gmail.com, broonie@kernel.org, a.zummo@towertech.it, alexandre.belloni@free-electrons.com, dianders@chromium.org, zyw@rock-chips.com Subject: Re: [RESEND PATCH v5 1/5] mfd: RK808: Add RK818 support Message-ID: <20160609152852.GA5438@dell> References: <1464850228-17244-1-git-send-email-w.egorov@phytec.de> <20160608141735.GE14888@dell> <5759277D.7090101@phytec.de> <20160609111201.GA1388@dell> <57596B1C.2010101@phytec.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <57596B1C.2010101@phytec.de> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 09 Jun 2016, Wadim Egorov wrote: > > > On 09.06.2016 13:12, Lee Jones wrote: > > On Thu, 09 Jun 2016, Wadim Egorov wrote: > >> On 08.06.2016 16:17, Lee Jones wrote: > >>> On Thu, 02 Jun 2016, Wadim Egorov wrote: > >>> > >>>> The RK818 chip is a power management IC for multimedia and handheld > >>> "Power Management IC (PMIC)" > >>> > >>>> devices. It contains the following components: > >>>> > >>>> - Regulators > >>>> - RTC > >>>> - Clkout > >>> Clocking > >>> > >>>> - battery support > >>> Battery support > >>> > >>>> Both chips RK808 and RK818 are using a similar register map. > >>> "Both RK808 ad RK818 chips" > >>> > >>>> So we can reuse the RTC and Clkout functionality. > >>> Swap '.' for ','. > >>> > >>>> Signed-off-by: Wadim Egorov > >>>> --- > >>>> drivers/mfd/Kconfig | 4 +- > >>>> drivers/mfd/rk808.c | 231 ++++++++++++++++++++++++++++++++++++++-------- > >>>> include/linux/mfd/rk808.h | 162 ++++++++++++++++++++++++++++++-- > >>>> 3 files changed, 350 insertions(+), 47 deletions(-) > > [...] > > > >>>> -struct rk808_reg_data { > >>>> - int addr; > >>>> - int mask; > >>>> - int value; > >>>> -}; > >>> Why are you moving this to the header? > >> It is now part of the rk808 struct. > > Why? > > > For me it seemed reasonable. My idea was to have only one chip variant > check. > > I can move the rk808_reg_data struct back to the c file, check for the > chip variant within the probe function and initialize the proper > reg_data variable. > This would also apply to the mfd_cell variables. 'struct rk808' should only contain information you wish to share with your subordinate/child devices. Any data only used in the parent/MFD driver should be declared, initialised and used only the latter. No need to export. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog