From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932726AbcFIPaG (ORCPT ); Thu, 9 Jun 2016 11:30:06 -0400 Received: from mail-wm0-f44.google.com ([74.125.82.44]:35347 "EHLO mail-wm0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932445AbcFIPaA (ORCPT ); Thu, 9 Jun 2016 11:30:00 -0400 Date: Thu, 9 Jun 2016 16:30:34 +0100 From: Lee Jones To: Linus Walleij Cc: Peter Griffin , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "open list:ARM/STI ARCHITECTURE" , Vinod Koul , Dan Williams , Leo Li , Zhang Wei , Barry Song , Maxime Ripard , Chen-Yu Tsai , Laxman Dewangan , Jon Hunter , Stephen Warren , Thierry Reding , Alexandre Courbot , dmaengine@vger.kernel.org, "linux-tegra@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org list" Subject: Re: [PATCH 8/8] dmaengine: Remove site specific OOM error messages on kzalloc Message-ID: <20160609153034.GB5438@dell> References: <1465321121-22238-1-git-send-email-peter.griffin@linaro.org> <1465321121-22238-9-git-send-email-peter.griffin@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 08 Jun 2016, Linus Walleij wrote: > On Tue, Jun 7, 2016 at 7:38 PM, Peter Griffin wrote: > > > If kzalloc() fails it will issue it's own error message including > > a dump_stack(). So remove the site specific error messages. > > > > Signed-off-by: Peter Griffin > > Acked-by: Linus Walleij > > A few subsystems may use a cleanup like this... > I wonder how many unnecessary prints I've introduced > myself :P Wolfram did some analysis on this a while back. IIRC he also presented on his findings at ELC(?). -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog