From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752806AbcFIPrn (ORCPT ); Thu, 9 Jun 2016 11:47:43 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:35000 "EHLO out2-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751799AbcFIPrm (ORCPT ); Thu, 9 Jun 2016 11:47:42 -0400 X-Sasl-enc: 3v8FVMlubyZJ5MXmpx4mrEQUESRMMqkwhqIBZVBQnJaU 1465487260 Date: Thu, 9 Jun 2016 12:47:37 -0300 From: Henrique de Moraes Holschuh To: "Elliott, Robert (Persistent Memory)" Cc: Andi Kleen , "x86@kernel.org" , "linux-kernel@vger.kernel.org" , Andi Kleen Subject: Re: [PATCH] x86/microcode/intel: Quieten down microcode updates on large systems Message-ID: <20160609154737.GA23149@khazad-dum.debian.net> References: <1464729764-108209-1-git-send-email-andi@firstfloor.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-GPG-Fingerprint1: 4096R/39CB4807 C467 A717 507B BAFE D3C1 6092 0BD9 E811 39CB 4807 User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 09 Jun 2016, Elliott, Robert (Persistent Memory) wrote: > > + if (val[1] != prev_rev) { > > + pr_info("CPU updated to revision 0x%x, date = %04x-%02x- > > %02x\n", > > "CPU(s)" would help convey that the messages now apply to one or > more CPUs. Agreed, especially because they *already* apply to more than one "cpu" (because cpu for the kernel is a hardware thread for the hardware, and updating the microcode for a core usually updates all threads hosted by that core, thus "several cpus"). And yes, Debian got one or two bugs about people getting confused because some "cpus" were never "listed" as being updated... Obviously, it is fine if a simple follow-up patch fixes this message to say "CPU(s)", or, if we really want to go for minimum chance of confusion: "One or more CPUs updated to...", as that will help a lot in mixed-stepping configurations, where you will get a few such messages, and just saying "CPU(s)" might cause people to get the wrong idea that the same set of CPUs have been updated several times. -- "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh