From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Andi Kleen <andi@firstfloor.org>
Cc: peterz@infradead.org, x86@kernel.org,
linux-kernel@vger.kernel.org, jolsa@kernel.org,
Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 2/2] perf stat: Remove nmi watchdog check code again
Date: Thu, 9 Jun 2016 14:20:10 -0300 [thread overview]
Message-ID: <20160609172010.GB1704@kernel.org> (raw)
In-Reply-To: <20160609151715.GM13997@two.firstfloor.org>
Em Thu, Jun 09, 2016 at 08:17:16AM -0700, Andi Kleen escreveu:
> On Thu, Jun 09, 2016 at 10:42:08AM -0300, Arnaldo Carvalho de Melo wrote:
> > Em Thu, Jun 09, 2016 at 06:14:39AM -0700, Andi Kleen escreveu:
> > > Now that the NMI watchdog runs with reference cycles, and does not
> > Now as in when? We should at least warn the user that the kernel used is
> > one where the NMI watchdog will not get in the way of topdown. Is there
> > a programmatic way to discover that?
> If the other patch gets merged at the same time as the TopDown patches
> it's only a few days in tip which don't support it, no released kernel.
> So no need to check for this case.
Ok, I see, since on older kernels it will fail before that point, when
not finding the topdown counters, no problem, super small window, thanks
for clarifying.
- Arnaldo
next prev parent reply other threads:[~2016-06-09 17:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-09 13:14 [PATCH 1/2] Switch NMI watchdog to ref cycles on x86 Andi Kleen
2016-06-09 13:14 ` [PATCH 2/2] perf stat: Remove nmi watchdog check code again Andi Kleen
2016-06-09 13:42 ` Arnaldo Carvalho de Melo
2016-06-09 15:17 ` Andi Kleen
2016-06-09 17:20 ` Arnaldo Carvalho de Melo [this message]
2016-06-10 19:03 ` Arnaldo Carvalho de Melo
2016-06-14 11:27 ` [tip:perf/core] perf/x86/intel, watchdog: Switch NMI watchdog to ref cycles on x86 tip-bot for Andi Kleen
-- strict thread matches above, loose matches on Subject: below --
2016-06-08 21:36 [PATCH 1/2] " Andi Kleen
2016-06-08 21:36 ` [PATCH 2/2] perf stat: Remove nmi watchdog check code again Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160609172010.GB1704@kernel.org \
--to=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).