From: Olaf Hering <olaf@aepfle.de>
To: James Bottomley <jejb@linux.vnet.ibm.com>
Cc: "K. Y. Srinivasan" <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
devel@linuxdriverproject.org, linux-kernel@vger.kernel.org,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH v3] storvsc: use small sg_tablesize on x86
Date: Fri, 10 Jun 2016 00:01:20 +0200 [thread overview]
Message-ID: <20160609220120.GA28607@aepfle.de> (raw)
In-Reply-To: <1465493159.2259.14.camel@linux.vnet.ibm.com>
On Thu, Jun 09, James Bottomley wrote:
> On Thu, 2016-06-09 at 18:25 +0200, Olaf Hering wrote:
> > Reducing the sg_tablesize allows booting of 32bit kernels in VMs,
> > after
> > commit be0cf6ca301c61458dc4aa1a37acf4f58d2ed3d6 ("scsi: storvsc: Set
> > the
> > tablesize based on the information given by the host")
> >
> > [ 5.567138] hv_storvsc vmbus_1: adjusting sg_tablesize 0x800 ->
> > 0x20
>
> Are you really sure 32 is the correct size?
Its a size that works, while the current state does not work at all.
> I know 32 it what it had before, but the reason for the commit you
> quote was to improve performance ...
The commit above broke 32bit. Whoever wants to improve performance on
this dead horse can submit another patch.
Olaf
next prev parent reply other threads:[~2016-06-09 22:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-09 16:25 [PATCH v3] storvsc: use small sg_tablesize on x86 Olaf Hering
2016-06-09 17:25 ` James Bottomley
2016-06-09 22:01 ` Olaf Hering [this message]
2016-06-15 2:07 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160609220120.GA28607@aepfle.de \
--to=olaf@aepfle.de \
--cc=devel@linuxdriverproject.org \
--cc=haiyangz@microsoft.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox