From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161068AbcFIWBd (ORCPT ); Thu, 9 Jun 2016 18:01:33 -0400 Received: from mo4-p00-ob.smtp.rzone.de ([81.169.146.217]:40133 "EHLO mo4-p00-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932860AbcFIWBa (ORCPT ); Thu, 9 Jun 2016 18:01:30 -0400 X-RZG-AUTH: :P2EQZWCpfu+qG7CngxMFH1J+yackYocTD1iAi8x+OWi/zfN1cLnDYUgpRwCBn4O91kkkm9tnVdmrvFpwnlLTYYXOzXqv X-RZG-CLASS-ID: mo00 Date: Fri, 10 Jun 2016 00:01:20 +0200 From: Olaf Hering To: James Bottomley Cc: "K. Y. Srinivasan" , Haiyang Zhang , "Martin K. Petersen" , devel@linuxdriverproject.org, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org Subject: Re: [PATCH v3] storvsc: use small sg_tablesize on x86 Message-ID: <20160609220120.GA28607@aepfle.de> References: <20160609162553.10290-1-olaf@aepfle.de> <1465493159.2259.14.camel@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1465493159.2259.14.camel@linux.vnet.ibm.com> User-Agent: Mutt/1.6.1 (6648) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 09, James Bottomley wrote: > On Thu, 2016-06-09 at 18:25 +0200, Olaf Hering wrote: > > Reducing the sg_tablesize allows booting of 32bit kernels in VMs, > > after > > commit be0cf6ca301c61458dc4aa1a37acf4f58d2ed3d6 ("scsi: storvsc: Set > > the > > tablesize based on the information given by the host") > > > > [ 5.567138] hv_storvsc vmbus_1: adjusting sg_tablesize 0x800 -> > > 0x20 > > Are you really sure 32 is the correct size? Its a size that works, while the current state does not work at all. > I know 32 it what it had before, but the reason for the commit you > quote was to improve performance ... The commit above broke 32bit. Whoever wants to improve performance on this dead horse can submit another patch. Olaf