From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S933038AbcFJMfx (ORCPT <rfc822;w@1wt.eu>);
	Fri, 10 Jun 2016 08:35:53 -0400
Received: from mga02.intel.com ([134.134.136.20]:49070 "EHLO mga02.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753400AbcFJMfv (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Fri, 10 Jun 2016 08:35:51 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.26,449,1459839600"; 
   d="scan'208";a="994995153"
Date: Fri, 10 Jun 2016 05:35:47 -0700
From: Jacob Pan <jacob.jun.pan@linux.intel.com>
To: Vince Weaver <vincent.weaver@maine.edu>
Cc: hpa@zytor.com, dave.hansen@linux.intel.com, mingo@kernel.org,
        linux-kernel@vger.kernel.org, acme@redhat.com, peterz@infradead.org,
        jolsa@redhat.com, eranian@google.com, tglx@linutronix.de,
        luto@amacapital.net, brgerst@gmail.com,
        alexander.shishkin@linux.intel.com, bp@alien8.de,
        torvalds@linux-foundation.org, dave@sr71.net, dvlasenk@redhat.com,
        linux-tip-commits@vger.kernel.org, jacob.jun.pan@linux.intel.com
Subject: Re: [tip:perf/core] perf/x86/rapl: Add Skylake server model
 detection
Message-ID: <20160610053547.731ea62d@yairi>
In-Reply-To: <alpine.DEB.2.20.1606081011370.5993@macbook-air>
References: <20160603001953.38848836@viggo.jf.intel.com>
	<tip-348c5ac6c7dc117e1de095bf07c86c31101d56f3@git.kernel.org>
	<alpine.DEB.2.20.1606081011370.5993@macbook-air>
Organization: OTC
X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.23; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 8 Jun 2016 10:12:58 -0400 (EDT)
Vince Weaver <vincent.weaver@maine.edu> wrote:

> On Wed, 8 Jun 2016, tip-bot for Jacob Pan wrote:
> 
> > Commit-ID:  348c5ac6c7dc117e1de095bf07c86c31101d56f3
> > Gitweb:
> > http://git.kernel.org/tip/348c5ac6c7dc117e1de095bf07c86c31101d56f3
> > Author:     Jacob Pan <jacob.jun.pan@linux.intel.com> AuthorDate:
> > Thu, 2 Jun 2016 17:19:53 -0700 Committer:  Ingo Molnar
> > <mingo@kernel.org> CommitDate: Wed, 8 Jun 2016 12:06:01 +0200
> > 
> > perf/x86/rapl: Add Skylake server model detection
> > 
> > SKX uses similar RAPL interface as Broadwell server.
> 
> ...
> 
> >  	X86_RAPL_MODEL_MATCH(INTEL_FAM6_SKYLAKE_MOBILE,
> > skl_rapl_init), X86_RAPL_MODEL_MATCH(INTEL_FAM6_SKYLAKE_DESKTOP,
> > skl_rapl_init),
> > +	X86_RAPL_MODEL_MATCH(INTEL_FAM6_SKYLAKE_X,
> > hsx_rapl_init),
> 
> 
> code does not match git commit message.  The code says that skylake
> server matches the haswell server.  (Yes I know broadwell server
> apparently matches haswell server too, but you might want to say that
> in the git commit to avoid confusion).
> 
Yes, it would be more clear to state that SKX matches BDX as well as
HSX. I was following the order of product releases. Should I submit a
patch for it? or can the commit message be changed by the maintainers?

New commit message:

"Skylake server (SKX) uses similar RAPL interface as Haswell server
which is used on Broadwell server as well."


Thanks for pointing it out.


Jacob