From: Daniel Vetter <daniel@ffwll.ch>
To: Doug Anderson <dianders@chromium.org>
Cc: Brian Norris <briannorris@chromium.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>,
Brian Norris <computersforpeace@gmail.com>
Subject: Re: [PATCH] drm/rockchip: fix compile warnings for 64-bit
Date: Fri, 10 Jun 2016 16:34:20 +0200 [thread overview]
Message-ID: <20160610143420.GE3363@phenom.ffwll.local> (raw)
In-Reply-To: <CAD=FV=VJ3TWJnP-OJO0LD=gBBra4zt_PowOLyUXLDV3U_RjnUA@mail.gmail.com>
On Thu, Jun 09, 2016 at 01:57:54PM -0700, Doug Anderson wrote:
> Brian,
>
> On Thu, Jun 9, 2016 at 10:46 AM, Brian Norris <briannorris@chromium.org> wrote:
> > Rockchip DRM does not yet build properly for ARM64, but we might as well
> > get the printf formatting correct now, to avoid the following warnings:
> >
> > drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c: In function 'rockchip_drm_fbdev_create':
> > drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c:111:2: warning: format '%d' expects argument of type 'int', but argument 8 has type 'size_t' [-Wformat=]
> > DRM_DEBUG_KMS("FB [%dx%d]-%d kvaddr=%p offset=%ld size=%d\n",
> > ^
> >
> > drivers/gpu/drm/rockchip/rockchip_drm_gem.c: In function 'rockchip_gem_alloc_buf':
> > drivers/gpu/drm/rockchip/rockchip_drm_gem.c:41:3: warning: format '%x' expects argument of type 'unsigned int', but argument 2 has type 'size_t' [-Wformat=]
> > DRM_ERROR("failed to allocate %#x byte dma buffer", obj->size);
> > ^
> >
> > Signed-off-by: Brian Norris <briannorris@chromium.org>
> > ---
> > drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c | 2 +-
> > drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 2 +-
> > 2 files changed, 2 insertions(+), 2 deletions(-)
>
> Reviewed-by: Douglas Anderson <dianders@chromium.org>
Applied to drm-misc, thanks.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
next prev parent reply other threads:[~2016-06-10 14:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-09 17:46 [PATCH] drm/rockchip: fix compile warnings for 64-bit Brian Norris
2016-06-09 20:57 ` Doug Anderson
2016-06-10 14:34 ` Daniel Vetter [this message]
2016-06-10 0:51 ` Caesar Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160610143420.GE3363@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=briannorris@chromium.org \
--cc=computersforpeace@gmail.com \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox