From: LABBE Corentin <clabbe.montjoie@gmail.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: davem@davemloft.net, baolin.wang@linaro.org,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/1] crypto: engine: permit to enqueue ashash_request
Date: Fri, 10 Jun 2016 16:43:09 +0200 [thread overview]
Message-ID: <20160610144309.GA25816@Red> (raw)
In-Reply-To: <20160607103139.GA325@gondor.apana.org.au>
On Tue, Jun 07, 2016 at 06:31:39PM +0800, Herbert Xu wrote:
> On Thu, Jun 02, 2016 at 03:13:32PM +0200, LABBE Corentin wrote:
> >
> > static int omap_aes_prepare_req(struct crypto_engine *engine,
> > - struct ablkcipher_request *req)
> > + struct crypto_async_request *areq)
> > {
> > + struct ablkcipher_request *req = ablkcipher_request_cast(areq);
>
> You're still doing casting in the driver.
>
> I want this to be moved into the crypto engine API. There should
> be separate function pointers for each request type.
>
> Thanks,
> --
So I need to split do_one_request to cipher_one_request/hash_one_request.
Same with prepare_request to prepare_hash_request/prepare_cipher_request.
With the choice of each function done in crypto_engine.c.
Since this modification need to add <crypto/hash.h> to algapi.h, I think it is necessary to move all crypto engine stuff to crypto/engine.h
Do you agree ?
Regards
next prev parent reply other threads:[~2016-06-10 14:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-02 13:13 [PATCH v3 0/1] crypto: engine: permit to enqueue ashash_request LABBE Corentin
2016-06-02 13:13 ` [PATCH v3 1/1] " LABBE Corentin
2016-06-07 10:31 ` Herbert Xu
2016-06-10 14:43 ` LABBE Corentin [this message]
2016-06-12 11:01 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160610144309.GA25816@Red \
--to=clabbe.montjoie@gmail.com \
--cc=baolin.wang@linaro.org \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox