From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Faccini, Bruno" <bruno.faccini@intel.com>
Cc: James Simmons <jsimmons@infradead.org>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
"Dilger, Andreas" <andreas.dilger@intel.com>,
"Drokin, Oleg" <oleg.drokin@intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Lustre Development List <lustre-devel@lists.lustre.org>
Subject: Re: [PATCH 2/3] staging: lustre: lnet: Allocate MEs and small MDs in own kmem_caches
Date: Fri, 10 Jun 2016 09:36:10 -0700 [thread overview]
Message-ID: <20160610163610.GA20291@kroah.com> (raw)
In-Reply-To: <B6A45EE2-D900-4578-AC42-4F5933F945DA@intel.com>
A: No.
Q: Should I include quotations after my reply?
http://daringfireball.net/2007/07/on_top
On Fri, Jun 10, 2016 at 03:25:28PM +0000, Faccini, Bruno wrote:
> Hello,
> The intent of this patch is not to solve the corruptions for sure, but
> only to avoid the concerned MEs/small-MDs LNet structs to be quite
> frequently impacted due to their high allocation/free rate.
But that's not what the patch description said :(
And again, putting them in a separate cache is not going to save much of
anything, given that your caches might have been merged together anyway.
> This may also possibly help to save cycles due to high usage and
> contention when using a generic kmem_cache (when they stay separate
> from others, thanks for the precision!).
Have you measured this?
This isn't applicable for 4.7-rc at this time, _unless_ it fixes a bug,
which is why I pushed back on this. If you want your own cache for
these variables, fine, I don't care, but that makes it a 4.8-rc1 patch
instead.
hope that helps explain things better,
greg k-h
next prev parent reply other threads:[~2016-06-10 16:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-09 22:45 [PATCH 0/3] staging: lustre: lnet: bug fixs for 4.7-rc2 James Simmons
2016-06-09 22:45 ` [PATCH 1/3] staging: lustre: lnet: Don't access NULL NI on failure path James Simmons
2016-06-09 22:45 ` [PATCH 2/3] staging: lustre: lnet: Allocate MEs and small MDs in own kmem_caches James Simmons
2016-06-10 1:28 ` Greg Kroah-Hartman
2016-06-10 15:25 ` Faccini, Bruno
2016-06-10 16:36 ` Greg Kroah-Hartman [this message]
2016-06-15 3:02 ` James Simmons
2016-06-18 3:32 ` Greg Kroah-Hartman
2016-06-09 22:45 ` [PATCH 3/3] staging: lustre: lnet: optimize memory foot print for lnet_libmd James Simmons
2016-06-10 1:28 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160610163610.GA20291@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=andreas.dilger@intel.com \
--cc=bruno.faccini@intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=jsimmons@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lustre-devel@lists.lustre.org \
--cc=oleg.drokin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox