From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753260AbcFJVPZ (ORCPT <rfc822;w@1wt.eu>);
	Fri, 10 Jun 2016 17:15:25 -0400
Received: from vps0.lunn.ch ([178.209.37.122]:41918 "EHLO vps0.lunn.ch"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753170AbcFJVPX (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Fri, 10 Jun 2016 17:15:23 -0400
Date: Fri, 10 Jun 2016 23:15:19 +0200
From: Andrew Lunn <andrew@lunn.ch>
To: Clemens Gruber <clemens.gruber@pqgruber.com>
Cc: netdev@vger.kernel.org, Florian Fainelli <f.fainelli@gmail.com>,
        linux-kernel@vger.kernel.org, "David S . Miller" <davem@davemloft.net>,
        Sergei Poselenov <sposelenov@emcraft.com>
Subject: Re: [PATCH] phy: marvell: remove LED config override
Message-ID: <20160610211519.GL2338@lunn.ch>
References: <20160610174252.14017-1-clemens.gruber@pqgruber.com>
 <20160610183857.GF2338@lunn.ch>
 <20160610205211.GA14243@archie.localdomain>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160610205211.GA14243@archie.localdomain>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> We could move that 0x30 LED configuration to .config_init instead of
> .config_aneg, so that if nobody configures it with marvell,reg-init, the
> behavior does not change. I'd have to create a new .config_init function
> for the 1121, 1318 and 1510.
> 
> Would you prefer that?

Hi Clemens

Yes, i would prefer that.

     Thanks
	Andrew