From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753136AbcFJWhl (ORCPT ); Fri, 10 Jun 2016 18:37:41 -0400 Received: from down.free-electrons.com ([37.187.137.238]:47314 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751801AbcFJWhk (ORCPT ); Fri, 10 Jun 2016 18:37:40 -0400 Date: Sat, 11 Jun 2016 00:37:38 +0200 From: Alexandre Belloni To: Arnd Bergmann Cc: linux-arm-kernel@lists.infradead.org, Nicolas Ferre , Boris Brezillon , Stephen Boyd , linux-kernel@vger.kernel.org, Cyrille Pitchen , Jean-Christophe Plagniol-Villard , linux-clk@vger.kernel.org Subject: Re: [PATCH 01/48] clk: at91: replace usleep() by udelay() calls Message-ID: <20160610223738.GF19050@piout.net> References: <1465596231-21766-1-git-send-email-alexandre.belloni@free-electrons.com> <1465596231-21766-2-git-send-email-alexandre.belloni@free-electrons.com> <11395561.bQatt85IOg@wuerfel> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <11395561.bQatt85IOg@wuerfel> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/06/2016 at 00:30:36 +0200, Arnd Bergmann wrote : > On Saturday, June 11, 2016 12:03:04 AM CEST Alexandre Belloni wrote: > > From: Cyrille Pitchen > > > > Fix the main and slow clock .prepare() implementations which used to call > > usleep() when the scheduler wasn't ready yet. > > > > Does this have to be called that early? It seems wasteful to always > call udelay() here, when these are functions that are normally > allowed to sleep. > Well, the main issue here is that we want to be able to prepare_enable the slow clock before we are allowed to sleep. Thinking about it when writing that, I realize that when I reworked my series, I removed the dependency between the clocksource TCB and the slow_clock. But I guess we still have one on the main clock. I'll check whether this is still necessary. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com