Re: [Cocci] [PATCH 4/4] coccicheck: add indexing enhancement options

Julia Lawall
2016-06-14T05:08:31Z

On Mon, 13 Jun 2016, Luis R. Rodriguez wrote:

> On Mon, Jun 13, 2016 at 09:48:30PM +0200, Julia Lawall wrote:
> >
> >
> > On Mon, 13 Jun 2016, Wolfram Sang wrote:
> >
> > >
> > > > Is there another scripts/coccinelle/ file I can use to test against to demo
> > > > against glimpse/idutils/gitgrep best?
> > >
> > > I'd think this one may be a candidate:
> > >
> > > scripts/coccinelle/misc/irqf_oneshot.cocci
> > >
> > > Not too many, but quite some matches over the tree.
> >
> > Seems like a reasonable choice.
>
> With this one on a 32-core system, I get:
>
> glimpse:
> real 0m6.549s
> user 0m49.136s
> sys 0m3.076s
>
> idutils:
> real 0m6.749s
> user 0m51.936s
> sys 0m3.876s
>
> gitgrep:
> real 0m6.805s
> user 0m51.572s
> sys 0m4.432s
>
> coccigrep:
> real 0m16.369s
> user 0m58.712s
> sys 0m5.064s
>
> I redirected stderr to stdout, and verified glimpse output has:
>
> glimpse request = request_threaded_irq
>
> Does this match expectations?

Yes. I'm not sure that gitgrep would work as well when there are multiple
keywords. It may descend to coccigrep.

julia