From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752438AbcFJXc0 (ORCPT ); Fri, 10 Jun 2016 19:32:26 -0400 Received: from mail.kernel.org ([198.145.29.136]:48582 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751354AbcFJXcY (ORCPT ); Fri, 10 Jun 2016 19:32:24 -0400 Date: Sat, 11 Jun 2016 08:32:14 +0900 From: Masami Hiramatsu To: Arnaldo Carvalho de Melo Cc: linux-kernel@vger.kernel.org, Namhyung Kim , Peter Zijlstra , Ingo Molnar , Hemant Kumar , Ananth N Mavinakayanahalli , Brendan Gregg Subject: Re: [PATCH perf/core v10 07/23] perf probe: Add --cache option to cache the probe definitions Message-Id: <20160611083214.2a74a8490c4719a82040262f@kernel.org> In-Reply-To: <20160609141850.GO11589@kernel.org> References: <20160608092854.3116.29007.stgit@devbox> <20160608093010.3116.42221.stgit@devbox> <20160609141850.GO11589@kernel.org> X-Mailer: Sylpheed 3.4.3 (GTK+ 2.24.28; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 9 Jun 2016 11:18:50 -0300 Arnaldo Carvalho de Melo wrote: > Em Wed, Jun 08, 2016 at 06:30:10PM +0900, Masami Hiramatsu escreveu: > > @@ -2555,6 +2556,14 @@ static int __add_probe_trace_events(struct perf_probe_event *pev, > > } > > if (ret == -EINVAL && pev->uprobes) > > warn_uprobe_event_compat(tev); > > + if (ret == 0 && probe_conf.cache) { > > + cache = probe_cache__new(pev->target); > > + if (cache) { > > + probe_cache__add_entry(cache, pev, tevs, ntevs); > > + probe_cache__commit(cache); > > These two functions may fail, please check its return and forward errors > appropriately. OK, will check and warn that. Thank you! -- Masami Hiramatsu