From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1422862AbcFMQwQ (ORCPT ); Mon, 13 Jun 2016 12:52:16 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:17585 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161166AbcFMQwP (ORCPT ); Mon, 13 Jun 2016 12:52:15 -0400 X-IBM-Helo: d01dlp03.pok.ibm.com X-IBM-MailFrom: paulmck@linux.vnet.ibm.com X-IBM-RcptTo: linux-kernel@vger.kernel.org Date: Mon, 13 Jun 2016 09:52:13 -0700 From: "Paul E. McKenney" To: weiyj_lk@163.com Cc: Josh Triplett , Steven Rostedt , Mathieu Desnoyers , Lai Jiangshan , Wei Yongjun , linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] rcutorture: Fix error return code in rcu_perf_init() Reply-To: paulmck@linux.vnet.ibm.com References: <1465831239-23815-1-git-send-email-weiyj_lk@163.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1465831239-23815-1-git-send-email-weiyj_lk@163.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16061316-0044-0000-0000-00000062EBB1 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16061316-0045-0000-0000-00000477EE10 Message-Id: <20160613165212.GB3923@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-06-13_09:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=2 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000 definitions=main-1606130188 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 13, 2016 at 03:20:39PM +0000, weiyj_lk@163.com wrote: > From: Wei Yongjun > > Fix to return a negative error code -ENOMEM from kcalloc() error > handling case instead of 0, as done elsewhere in this function. > > Signed-off-by: Wei Yongjun Good eyes! Queued for review and testing. Thanx, Paul > --- > kernel/rcu/rcuperf.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/kernel/rcu/rcuperf.c b/kernel/rcu/rcuperf.c > index 7b2dbdf..d38ab08 100644 > --- a/kernel/rcu/rcuperf.c > +++ b/kernel/rcu/rcuperf.c > @@ -638,8 +638,10 @@ rcu_perf_init(void) > writer_durations[i] = > kcalloc(MAX_MEAS, sizeof(*writer_durations[i]), > GFP_KERNEL); > - if (!writer_durations[i]) > + if (!writer_durations[i]) { > + firsterr = -ENOMEM; > goto unwind; > + } > firsterr = torture_create_kthread(rcu_perf_writer, (void *)i, > writer_tasks[i]); > if (firsterr) > >