From: Bin Gao <bin.gao@linux.intel.com>
To: Aaron Lu <aaron.lu@intel.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Paul Gortmaker <paul.gortmaker@windriver.com>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
ysiyer <yegnesh.s.iyer@intel.com>,
Ajay Thomas <ajay.thomas.david.rajamanickam@intel.com>,
Bin Gao <bin.gao@intel.com>
Subject: Re: [PATCH 2/2] acpi/pmic: Add opregion driver for Intel BXT WhiskeyCove PMIC
Date: Mon, 13 Jun 2016 10:38:02 -0700 [thread overview]
Message-ID: <20160613173801.GA202077@worksta> (raw)
In-Reply-To: <54020215-86ac-77be-ea4f-19941ed3a176@intel.com>
On Sun, Jun 12, 2016 at 10:13:33AM +0800, Aaron Lu wrote:
> Last time Paul suggests device_initcall instead of module_init here:
>
> commit 75829dcf10862966f52716f2d67ac1c1b1eb486b
> Author: Paul Gortmaker <paul.gortmaker@windriver.com>
> Date: Mon Feb 15 00:27:51 2016 -0500
>
> drivers/acpi: make pmic/intel_pmic_crc.c explicitly non-modular
>
> Perhaps you should do the same.
Thanks Aaron's review.
I just sent out v2 of the patches which addressed your comments.
prev parent reply other threads:[~2016-06-13 17:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-11 7:25 [PATCH 2/2] acpi/pmic: Add opregion driver for Intel BXT WhiskeyCove PMIC Bin Gao
2016-06-12 2:13 ` Aaron Lu
2016-06-13 17:38 ` Bin Gao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160613173801.GA202077@worksta \
--to=bin.gao@linux.intel.com \
--cc=aaron.lu@intel.com \
--cc=ajay.thomas.david.rajamanickam@intel.com \
--cc=bin.gao@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=rjw@rjwysocki.net \
--cc=yegnesh.s.iyer@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox