From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753712AbcFNBeI (ORCPT ); Mon, 13 Jun 2016 21:34:08 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:50394 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753665AbcFNBeG (ORCPT ); Mon, 13 Jun 2016 21:34:06 -0400 Date: Mon, 13 Jun 2016 18:34:01 -0700 From: Greg Kroah-Hartman To: Ben Dooks Cc: linux-kernel@lists.codethink.co.uk, Arnd Bergmann , Philipp Zabel , Alan Stern , Peter Chen , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] USB: core: fix missing include Message-ID: <20160614013401.GA24636@kroah.com> References: <1465323633-4851-1-git-send-email-ben.dooks@codethink.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1465323633-4851-1-git-send-email-ben.dooks@codethink.co.uk> User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 07, 2016 at 07:20:33PM +0100, Ben Dooks wrote: > The helper function usb_of_get_child_node() is defined in the > header but this was not included. Fix the warning > about usb_of_get_child_node() not being declared by adding the > right include. Fixes: > > drivers/usb/core/of.c:31:20: warning: symbol 'usb_of_get_child_node' was not declared. Should it be static? > > Signed-off-by: Ben Dooks Given that the kbuild robot broke with this patch, I'm not going to take it...