From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Bin Gao <bin.gao@linux.intel.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Alexandre Courbot <gnurou@gmail.com>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
Ajay Thomas <ajay.thomas.david.rajamanickam@intel.com>,
Bin Gao <bin.gao@intel.com>
Subject: Re: [PATCH] gpio: add Intel WhiskeyCove GPIO driver
Date: Tue, 14 Jun 2016 13:09:31 +0300 [thread overview]
Message-ID: <20160614100931.GJ1740@lahna.fi.intel.com> (raw)
In-Reply-To: <20160611060150.GA88066@worksta>
On Fri, Jun 10, 2016 at 11:01:51PM -0700, Bin Gao wrote:
> +static const struct platform_device_id pmic_gpio_id_table[] = {
> + { "bxt_wcove_gpio", },
> +};
Do you really need this?
> +
> +static struct platform_driver wcove_gpio_driver = {
> + .probe = wcove_gpio_probe,
> + .remove = wcove_gpio_remove,
> + .driver = {
> + .name = "wcove_gpio",
> + },
> + .id_table = pmic_gpio_id_table,
and this?
> +};
> +
> +module_platform_driver(wcove_gpio_driver);
> +
> +MODULE_AUTHOR("Ajay Thomas <ajay.thomas.david.rajamanickam@intel.com>");
> +MODULE_DESCRIPTION("Intel Whiskey Cove GPIO Driver");
> +MODULE_LICENSE("GPL v2");
You can add
MODULE_ALIAS("platform:wcove_gpio");
to get the module loaded automatically.
next prev parent reply other threads:[~2016-06-14 10:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-11 6:01 [PATCH] gpio: add Intel WhiskeyCove GPIO driver Bin Gao
2016-06-13 12:43 ` Linus Walleij
2016-06-13 22:40 ` Bin Gao
2016-06-14 10:09 ` Mika Westerberg [this message]
2016-06-14 23:39 ` Bin Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160614100931.GJ1740@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=ajay.thomas.david.rajamanickam@intel.com \
--cc=bin.gao@intel.com \
--cc=bin.gao@linux.intel.com \
--cc=gnurou@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox