Re: [PATCH] mmc: Change the enhanced area related sysfs output format

Wolfram Sang
2016-06-14T12:41:20Z

[-- Attachment #1: Type: text/plain, Size: 876 bytes --]

On Tue, Jun 14, 2016 at 01:36:11PM +0300, Adrian Hunter wrote:
> On 14/06/16 13:12, Wolfram Sang wrote:
> > On Tue, Jun 14, 2016 at 10:33:06AM +0200, Beata Baranowska wrote:
> >> From: Chuanxiao Dong <chuanxiao.dong@intel.com>
> >>
> >> When the enhanced area feature was not enabled, the related sysfs will
> >> have -EINVAL(-22) value, so change the sysfs output format to display
> >> the correct value.
> >>
> >> Signed-off-by: Chuanxiao Dong <chuanxiao.dong@intel.com>
> >
> > What about introducing attribute_group an use the is_visible callback
> > there, so they won't get displayed at all?
> >
>
> Except that it is an ABI:
>
> Documentation/ABI/testing/sysfs-devices-mmc

And broken ever since if this patch is needed... that being said, I
don't really have a strong opinion on my suggestion. I see the file is
out there for >5 years.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]