From: Wolfram Sang <wsa@the-dreams.de>
To: Adrian Hunter <adrian.hunter@intel.com>
Cc: Beata Baranowska <beatax.baranowska@intel.com>,
ulf.hansson@linaro.org, aisheng.dong@nxp.com,
wsa+renesas@sang-engineering.com, gwendal@chromium.org,
chaotian.jing@mediatek.com, linux-mmc@vger.kernel.org,
linux-kernel@vger.kernel.org, sebastianx.jarosz@intel.com,
Chuanxiao Dong <chuanxiao.dong@intel.com>
Subject: Re: [PATCH] mmc: Change the enhanced area related sysfs output format
Date: Tue, 14 Jun 2016 14:41:00 +0200 [thread overview]
Message-ID: <20160614124100.GA1608@katana> (raw)
In-Reply-To: <575FDE1B.2090206@intel.com>
[-- Attachment #1: Type: text/plain, Size: 876 bytes --]
On Tue, Jun 14, 2016 at 01:36:11PM +0300, Adrian Hunter wrote:
> On 14/06/16 13:12, Wolfram Sang wrote:
> > On Tue, Jun 14, 2016 at 10:33:06AM +0200, Beata Baranowska wrote:
> >> From: Chuanxiao Dong <chuanxiao.dong@intel.com>
> >>
> >> When the enhanced area feature was not enabled, the related sysfs will
> >> have -EINVAL(-22) value, so change the sysfs output format to display
> >> the correct value.
> >>
> >> Signed-off-by: Chuanxiao Dong <chuanxiao.dong@intel.com>
> >
> > What about introducing attribute_group an use the is_visible callback
> > there, so they won't get displayed at all?
> >
>
> Except that it is an ABI:
>
> Documentation/ABI/testing/sysfs-devices-mmc
And broken ever since if this patch is needed... that being said, I
don't really have a strong opinion on my suggestion. I see the file is
out there for >5 years.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-06-14 12:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-14 8:33 [PATCH] mmc: Change the enhanced area related sysfs output format Beata Baranowska
2016-06-14 10:12 ` Wolfram Sang
2016-06-14 10:36 ` Adrian Hunter
2016-06-14 12:41 ` Wolfram Sang [this message]
2016-06-20 9:25 ` Baranowska, BeataX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160614124100.GA1608@katana \
--to=wsa@the-dreams.de \
--cc=adrian.hunter@intel.com \
--cc=aisheng.dong@nxp.com \
--cc=beatax.baranowska@intel.com \
--cc=chaotian.jing@mediatek.com \
--cc=chuanxiao.dong@intel.com \
--cc=gwendal@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=sebastianx.jarosz@intel.com \
--cc=ulf.hansson@linaro.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox