From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Jens Axboe <axboe@kernel.dk>, David Sterba <dsterba@suse.cz>
Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
Mike Christie <mchristi@redhat.com>,
Liu Bo <bo.li.liu@oracle.com>
Subject: linux-next: manual merge of the block tree with the btrfs tree
Date: Tue, 14 Jun 2016 12:44:51 +1000 [thread overview]
Message-ID: <20160614124451.25bbe808@canb.auug.org.au> (raw)
Hi Jens,
Today's linux-next merge of the block tree got a conflict in:
fs/btrfs/extent_io.c
between commit:
f338d193e1c5 ("Btrfs: fix eb memory leak due to readpage failure")
from the btrfs tree and commit:
1f7ad75b13b5 ("btrfs: have submit_one_bio users use bio op accessors")
from the block tree.
I fixed it up (see below) and can carry the fix as necessary. This
is now fixed as far as linux-next is concerned, but any non trivial
conflicts should be mentioned to your upstream maintainer when your tree
is submitted for merging. You may also want to consider cooperating
with the maintainer of the conflicting tree to minimise any particularly
complex conflicts.
--
Cheers,
Stephen Rothwell
diff --cc fs/btrfs/extent_io.c
index b8ecc6af4531,4f8bace0fd1b..000000000000
--- a/fs/btrfs/extent_io.c
+++ b/fs/btrfs/extent_io.c
@@@ -5253,18 -5225,9 +5251,18 @@@ int read_extent_buffer_pages(struct ext
err = __extent_read_full_page(tree, page,
get_extent, &bio,
mirror_num, &bio_flags,
- READ | REQ_META);
+ REQ_META);
- if (err)
+ if (err) {
ret = err;
+ /*
+ * We use &bio in above __extent_read_full_page,
+ * so we ensure that if it returns error, the
+ * current page fails to add itself to bio.
+ *
+ * We must dec io_pages by ourselves.
+ */
+ atomic_dec(&eb->io_pages);
+ }
} else {
unlock_page(page);
}
next reply other threads:[~2016-06-14 2:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-14 2:44 Stephen Rothwell [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-12-21 2:45 linux-next: manual merge of the block tree with the btrfs tree Stephen Rothwell
2023-12-21 5:23 ` Christoph Hellwig
2022-07-15 3:25 Stephen Rothwell
2021-02-02 2:45 Stephen Rothwell
2021-02-14 22:17 ` Stephen Rothwell
2020-12-07 2:44 Stephen Rothwell
2020-07-09 2:58 Stephen Rothwell
2015-08-24 4:16 Stephen Rothwell
2015-08-24 4:16 Stephen Rothwell
2015-08-24 4:15 Stephen Rothwell
2015-08-24 4:15 Stephen Rothwell
2014-01-09 4:01 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160614124451.25bbe808@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=axboe@kernel.dk \
--cc=bo.li.liu@oracle.com \
--cc=dsterba@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=mchristi@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox