From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751559AbcFNOlL (ORCPT ); Tue, 14 Jun 2016 10:41:11 -0400 Received: from outbound-smtp06.blacknight.com ([81.17.249.39]:57215 "EHLO outbound-smtp06.blacknight.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751220AbcFNOlH (ORCPT ); Tue, 14 Jun 2016 10:41:07 -0400 Date: Tue, 14 Jun 2016 15:41:03 +0100 From: Mel Gorman To: Vlastimil Babka Cc: Andrew Morton , Linux-MM , Rik van Riel , Johannes Weiner , LKML , Peter Zijlstra Subject: Re: [PATCH 02/27] mm, vmscan: Move lru_lock to the node Message-ID: <20160614144103.GB1868@techsingularity.net> References: <1465495483-11855-1-git-send-email-mgorman@techsingularity.net> <1465495483-11855-3-git-send-email-mgorman@techsingularity.net> <575AED3E.3090705@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <575AED3E.3090705@suse.cz> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 10, 2016 at 06:39:26PM +0200, Vlastimil Babka wrote: > > @@ -5944,10 +5944,10 @@ static void __paginginit free_area_init_core(struct pglist_data *pgdat) > > zone->min_slab_pages = (freesize * sysctl_min_slab_ratio) / 100; > > #endif > > zone->name = zone_names[j]; > > + zone->zone_pgdat = pgdat; > > spin_lock_init(&zone->lock); > > - spin_lock_init(&zone->lru_lock); > > + spin_lock_init(zone_lru_lock(zone)); > > This means the same lock will be inited MAX_NR_ZONES times. Peterz told > me it's valid but weird. Probably better to do it just once, in case > lockdep/lock debugging gains some checks for that? > Good point and it's an easy fix. -- Mel Gorman SUSE Labs