From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932238AbcFNRsX (ORCPT ); Tue, 14 Jun 2016 13:48:23 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:46673 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752912AbcFNRsU (ORCPT ); Tue, 14 Jun 2016 13:48:20 -0400 Date: Tue, 14 Jun 2016 10:48:18 -0700 From: Stephen Boyd To: Bjorn Andersson Cc: Rob Herring , Mark Rutland , Andy Gross , Srinivas Kandagatla , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org Subject: Re: [PATCH] firmware: qcom: scm: Expose PAS command 10 as reset-controller Message-ID: <20160614174818.GD28218@codeaurora.org> References: <1465620740-24474-1-git-send-email-bjorn.andersson@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1465620740-24474-1-git-send-email-bjorn.andersson@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/10, Bjorn Andersson wrote: > PAS command 10 is used to assert and deassert the MSS reset via > TrustZone, expose this as a reset-controller to follow the non-secure > case where GCC exposes this control. > > Signed-off-by: Bjorn Andersson > --- > .../devicetree/bindings/firmware/qcom,scm.txt | 6 ++++ > drivers/firmware/qcom_scm-32.c | 13 +++++++++ > drivers/firmware/qcom_scm-64.c | 17 +++++++++++ > drivers/firmware/qcom_scm.c | 34 ++++++++++++++++++++++ > drivers/firmware/qcom_scm.h | 2 ++ We should add some sort of select for the reset controller config in SCM? > diff --git a/drivers/firmware/qcom_scm.c b/drivers/firmware/qcom_scm.c > index 79bb0b00577e..b0119535c0fb 100644 > --- a/drivers/firmware/qcom_scm.c > +++ b/drivers/firmware/qcom_scm.c > @@ -21,6 +21,7 @@ > > + > +static struct reset_control_ops qcom_scm_pas_reset_ops = { const? > + .assert = qcom_scm_pas_reset_assert, > + .deassert = qcom_scm_pas_reset_deassert, > +}; > + > static int qcom_scm_probe(struct platform_device *pdev) > { > struct qcom_scm *scm; -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project