From: Al Viro <viro@ZenIV.linux.org.uk>
To: Jiri Kosina <jikos@kernel.org>
Cc: Wim Osterholt <wim@djo.tudelft.nl>, linux-kernel@vger.kernel.org
Subject: Re: disfunctional floppy driver in kernels 4.5, 4.6 and 4.7
Date: Tue, 14 Jun 2016 20:09:23 +0100 [thread overview]
Message-ID: <20160614190923.GX14480@ZenIV.linux.org.uk> (raw)
In-Reply-To: <alpine.LNX.2.00.1606131414420.6874@cbobk.fhfr.pm>
On Mon, Jun 13, 2016 at 02:15:15PM +0200, Jiri Kosina wrote:
> Hmm, could you please test with 09954bad448 reverted? (although I don't
> really have a good explanation currently how it'd be causing what you are
> observing).
I do, actually - ->f_mode on open(..., 3) contains neither FMODE_READ nor
FMODE_WRITE. So this
While at it, clean up a bit handling of !(mode & (FMODE_READ|FMODE_WRITE))
case and return EINVAL instead of succeeding as well.
is working as promised in commit message.
prev parent reply other threads:[~2016-06-14 19:09 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-10 23:02 disfunctional floppy driver in kernels 4.5, 4.6 and 4.7 Wim Osterholt
2016-06-11 13:15 ` VFS regression ? " One Thousand Gnomes
2016-06-12 0:23 ` Wim Osterholt
2016-06-13 12:15 ` Jiri Kosina
2016-06-14 18:43 ` Wim Osterholt
2016-06-15 7:09 ` Jiri Kosina
2016-06-15 11:42 ` Wim Osterholt
2016-06-15 13:20 ` Al Viro
2016-06-15 14:13 ` Jiri Kosina
2016-06-15 22:47 ` Wim Osterholt
2016-06-16 7:53 ` [PATCH] floppy: fix open(O_ACCMODE) for ioctl-only open Jiri Kosina
2016-06-30 11:18 ` [PATCH RESEND] " Jiri Kosina
2016-07-25 18:09 ` Wim Osterholt
2016-07-25 20:48 ` Jens Axboe
2021-01-19 15:53 ` Jiri Kosina
2021-01-21 4:44 ` Denis Efremov
2021-01-21 10:25 ` Jiri Kosina
2021-01-21 13:28 ` [PATCH] floppy: reintroduce O_NDELAY fix kernel test robot
2021-01-21 14:44 ` [PATCH RESEND] floppy: fix open(O_ACCMODE) for ioctl-only open Jiri Kosina
2021-01-21 15:02 ` Denis Efremov
2021-01-21 15:05 ` Jiri Kosina
2021-01-22 11:13 ` [PATCH] floppy: reintroduce O_NDELAY fix Jiri Kosina
2021-01-26 8:21 ` Denis Efremov
2021-01-26 9:31 ` Kurt Garloff
2021-01-26 9:59 ` Denis Efremov
2021-02-04 9:24 ` Jiri Kosina
2021-02-04 10:18 ` Denis Efremov
2021-01-21 14:45 ` [PATCH RESEND] floppy: fix open(O_ACCMODE) for ioctl-only open Denis Efremov
2016-06-15 23:07 ` disfunctional floppy driver in kernels 4.5, 4.6 and 4.7 Wim Osterholt
2016-06-15 23:12 ` Jiri Kosina
2016-06-15 23:13 ` Joe Perches
2016-06-14 19:09 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160614190923.GX14480@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=jikos@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wim@djo.tudelft.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox