From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752979AbcFNWyZ (ORCPT ); Tue, 14 Jun 2016 18:54:25 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:24743 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751494AbcFNWyX (ORCPT ); Tue, 14 Jun 2016 18:54:23 -0400 X-IBM-Helo: d01dlp03.pok.ibm.com X-IBM-MailFrom: paulmck@linux.vnet.ibm.com X-IBM-RcptTo: linux-kernel@vger.kernel.org Date: Tue, 14 Jun 2016 15:54:17 -0700 From: "Paul E. McKenney" To: kbuild test robot Cc: kbuild-all@01.org, linux-kernel@vger.kernel.org, jdike@addtoit.com, richard@nod.at, user-mode-linux-devel@lists.sourceforge.net Subject: Re: [rcu:rcu/next 25/36] include/linux/irqflags.h:79:3: error: implicit declaration of function 'arch_irqs_disabled_flags' Reply-To: paulmck@linux.vnet.ibm.com References: <201606060200.kVmeQzvA%fengguang.wu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201606060200.kVmeQzvA%fengguang.wu@intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16061422-0056-0000-0000-000000852A9F X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16061422-0057-0000-0000-0000049E83AE Message-Id: <20160614225417.GR3923@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-06-14_10:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000 definitions=main-1606140249 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 06, 2016 at 02:04:03AM +0800, kbuild test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git rcu/next > head: 13ee0de9cd2444b57ce30c4f1607b49b90aa0c38 > commit: f251ac814fc5787765009e60d54a2bd4277350c8 [25/36] rcu: Make call_rcu_tasks() tolerate first call with irqs disabled > config: um-allmodconfig (attached as .config) > compiler: gcc-6 (Debian 6.1.1-1) 6.1.1 20160430 > reproduce: > git checkout f251ac814fc5787765009e60d54a2bd4277350c8 > # save the attached .config to linux build tree > make ARCH=um My kneejerk reaction would be to make CONFIG_TASKS_RCU depend on !UML or something similar. Another approach would be create a arch_irqs_disabled_flags() for UML. Any preferences? Thanx, Paul > All errors (new ones prefixed by >>): > > In file included from include/linux/spinlock.h:53:0, > from kernel/rcu/update.c:36: > kernel/rcu/update.c: In function 'call_rcu_tasks': > >> include/linux/irqflags.h:79:3: error: implicit declaration of function 'arch_irqs_disabled_flags' [-Werror=implicit-function-declaration] > arch_irqs_disabled_flags(flags); \ > ^ > include/linux/irqflags.h:149:36: note: in expansion of macro 'raw_irqs_disabled_flags' > #define irqs_disabled_flags(flags) raw_irqs_disabled_flags(flags) > ^~~~~~~~~~~~~~~~~~~~~~~ > kernel/rcu/update.c:572:21: note: in expansion of macro 'irqs_disabled_flags' > (!havetask && !irqs_disabled_flags(flags))) { > ^~~~~~~~~~~~~~~~~~~ > cc1: some warnings being treated as errors > > vim +/arch_irqs_disabled_flags +79 include/linux/irqflags.h > > df9ee292 David Howells 2010-10-07 73 typecheck(unsigned long, flags); \ > df9ee292 David Howells 2010-10-07 74 flags = arch_local_save_flags(); \ > df9ee292 David Howells 2010-10-07 75 } while (0) > df9ee292 David Howells 2010-10-07 76 #define raw_irqs_disabled_flags(flags) \ > df9ee292 David Howells 2010-10-07 77 ({ \ > df9ee292 David Howells 2010-10-07 78 typecheck(unsigned long, flags); \ > df9ee292 David Howells 2010-10-07 @79 arch_irqs_disabled_flags(flags); \ > df9ee292 David Howells 2010-10-07 80 }) > df9ee292 David Howells 2010-10-07 81 #define raw_irqs_disabled() (arch_irqs_disabled()) > df9ee292 David Howells 2010-10-07 82 #define raw_safe_halt() arch_safe_halt() > > :::::: The code at line 79 was first introduced by commit > :::::: df9ee29270c11dba7d0fe0b83ce47a4d8e8d2101 Fix IRQ flag handling naming > > :::::: TO: David Howells > :::::: CC: David Howells > > --- > 0-DAY kernel test infrastructure Open Source Technology Center > https://lists.01.org/pipermail/kbuild-all Intel Corporation