From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752274AbcFNXfq (ORCPT <rfc822;w@1wt.eu>);
	Tue, 14 Jun 2016 19:35:46 -0400
Received: from mga14.intel.com ([192.55.52.115]:58847 "EHLO mga14.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751190AbcFNXfo (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 14 Jun 2016 19:35:44 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.26,473,1459839600"; 
   d="scan'208";a="997737758"
Date: Tue, 14 Jun 2016 16:39:27 -0700
From: Bin Gao <bin.gao@linux.intel.com>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
        Alexandre Courbot <gnurou@gmail.com>, linux-gpio@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Ajay Thomas <ajay.thomas.david.rajamanickam@intel.com>,
        Bin Gao <bin.gao@intel.com>
Subject: Re: [PATCH] gpio: add Intel WhiskeyCove GPIO driver
Message-ID: <20160614233927.GA25061@worksta>
References: <20160611060150.GA88066@worksta>
 <20160614100931.GJ1740@lahna.fi.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160614100931.GJ1740@lahna.fi.intel.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jun 14, 2016 at 01:09:31PM +0300, Mika Westerberg wrote:
> On Fri, Jun 10, 2016 at 11:01:51PM -0700, Bin Gao wrote:
> > +static const struct platform_device_id pmic_gpio_id_table[] = {
> > +	{ "bxt_wcove_gpio", },
> > +};
> 
> Do you really need this?
> 
> > +
> > +static struct platform_driver wcove_gpio_driver = {
> > +	.probe = wcove_gpio_probe,
> > +	.remove = wcove_gpio_remove,
> > +	.driver = {
> > +		.name = "wcove_gpio",
> > +	},
> > +	.id_table = pmic_gpio_id_table,
> 
> and this?
> 
> > +};
> > +
> > +module_platform_driver(wcove_gpio_driver);
> > +
> > +MODULE_AUTHOR("Ajay Thomas <ajay.thomas.david.rajamanickam@intel.com>");
> > +MODULE_DESCRIPTION("Intel Whiskey Cove GPIO Driver");
> > +MODULE_LICENSE("GPL v2");
> 
> You can add
> 
> MODULE_ALIAS("platform:wcove_gpio");
> 
> to get the module loaded automatically.

Mika,
Thanks for your review. I'll address these in patch v2.

-Bin