From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932530AbcFOCuK (ORCPT ); Tue, 14 Jun 2016 22:50:10 -0400 Received: from mail-pa0-f67.google.com ([209.85.220.67]:35588 "EHLO mail-pa0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752938AbcFOCuH (ORCPT ); Tue, 14 Jun 2016 22:50:07 -0400 Date: Wed, 15 Jun 2016 10:43:55 +0800 From: Peter Chen To: Arnd Bergmann Cc: kbuild test robot , Ben Dooks , kbuild-all@01.org, linux-kernel@lists.codethink.co.uk, Greg Kroah-Hartman , Philipp Zabel , Alan Stern , Peter Chen , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] USB: core: fix missing include Message-ID: <20160615024355.GB4049@shlinux2> References: <201606080333.vfFKvIIV%fengguang.wu@intel.com> <16060867.1nFmu0b2lQ@wuerfel> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <16060867.1nFmu0b2lQ@wuerfel> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 14, 2016 at 01:08:08PM +0200, Arnd Bergmann wrote: > On Wednesday, June 8, 2016 3:04:27 AM CEST kbuild test robot wrote: > > >> drivers/usb/core/of.c:32:21: error: redefinition of 'usb_of_get_child_node' > > struct device_node *usb_of_get_child_node(struct device_node *parent, > > ^~~~~~~~~~~~~~~~~~~~~ > > In file included from drivers/usb/core/of.c:21:0: > > include/linux/usb/of.h:36:35: note: previous definition of 'usb_of_get_child_node' was here > > static inline struct device_node *usb_of_get_child_node > > ^~~~~~~~~~~~~~~~~~~~~ > > > > vim +/usb_of_get_child_node +32 drivers/usb/core/of.c > > > > 69bec725 Peter Chen 2016-02-19 26 * @portnum: the port number which device is connecting > > 69bec725 Peter Chen 2016-02-19 27 * > > 69bec725 Peter Chen 2016-02-19 28 * Find the node from device tree according to its port number. > > 69bec725 Peter Chen 2016-02-19 29 * > > 69bec725 Peter Chen 2016-02-19 30 * Return: On success, a pointer to the device node, %NULL on failure. > > 69bec725 Peter Chen 2016-02-19 31 */ > > 69bec725 Peter Chen 2016-02-19 @32 struct device_node *usb_of_get_child_node(struct device_node *parent, > > 69bec725 Peter Chen 2016-02-19 33 int portnum) > > 69bec725 Peter Chen 2016-02-19 34 { > > 69bec725 Peter Chen 2016-02-19 35 struct device_node *node; > > > > > > I think what we want here is to make the compilation of of.o conditional on > CONFIG_OF, so we get only one of the two definitions. > > Arnd Thanks, Arnd. It is the correct solution, I will send patch soon. -- Best Regards, Peter Chen