From: Masami Hiramatsu <mhiramat@kernel.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Masami Hiramatsu <mhiramat@kernel.org>,
linux-kernel@vger.kernel.org, Namhyung Kim <namhyung@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Hemant Kumar <hemant@linux.vnet.ibm.com>,
Ananth N Mavinakayanahalli <ananth@linux.vnet.ibm.com>,
Brendan Gregg <brendan.d.gregg@gmail.com>
Subject: [PATCH perf/core v11 02/23] perf-probe: Fix to add NULL check for strndup
Date: Wed, 15 Jun 2016 12:39:50 +0900 [thread overview]
Message-ID: <20160615033950.2064.1796.stgit@devbox> (raw)
In-Reply-To: <20160615033925.2064.31216.stgit@devbox>
Fix to add a NULL check for strndup when parsing
probe trace command.
Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
---
Changes in v10:
- Splited from "perf probe: Allow wildcard for cached events"
---
tools/perf/util/probe-event.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c
index 74401a2..7ae3dd1 100644
--- a/tools/perf/util/probe-event.c
+++ b/tools/perf/util/probe-event.c
@@ -1603,6 +1603,10 @@ int parse_probe_trace_command(const char *cmd, struct probe_trace_event *tev)
p = strchr(argv[1], ':');
if (p) {
tp->module = strndup(argv[1], p - argv[1]);
+ if (!tp->module) {
+ ret = -ENOMEM;
+ goto out;
+ }
p++;
} else
p = argv[1];
next prev parent reply other threads:[~2016-06-15 3:40 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-15 3:39 [PATCH perf/core v11 00/23] perf-probe --cache and SDT support Masami Hiramatsu
2016-06-15 3:39 ` [PATCH perf/core v11 01/23] perf: util: Fix rm_rf() to handle non-regular files correctly Masami Hiramatsu
2016-06-15 3:39 ` Masami Hiramatsu [this message]
2016-06-15 3:40 ` [PATCH perf/core v11 03/23] perf-buildid: Rename and export build_id_cache__cachedir() Masami Hiramatsu
2016-06-15 3:40 ` [PATCH perf/core v11 04/23] perf probe: Add perf_probe_event__copy() Masami Hiramatsu
2016-06-15 3:40 ` [PATCH perf/core v11 05/23] perf probe: Recover and export synthesize_perf_probe_point() Masami Hiramatsu
2016-06-15 3:40 ` [PATCH perf/core v11 06/23] perf probe-file: Introduce perf_cache interfaces Masami Hiramatsu
2016-06-15 3:40 ` [PATCH perf/core v11 07/23] perf probe: Add --cache option to cache the probe definitions Masami Hiramatsu
2016-06-15 3:40 ` [PATCH perf/core v11 08/23] perf probe: Use cache entry if possible Masami Hiramatsu
2016-06-15 3:41 ` [PATCH perf/core v11 09/23] perf probe: Show all cached probes Masami Hiramatsu
2016-06-15 3:41 ` [PATCH perf/core v11 10/23] perf probe: Remove caches when --cache is given Masami Hiramatsu
2016-06-15 3:41 ` [PATCH perf/core v11 11/23] perf/sdt: ELF support for SDT Masami Hiramatsu
2016-06-15 3:41 ` [PATCH perf/core v11 12/23] perf probe: Add group name support Masami Hiramatsu
2016-06-15 3:41 ` [PATCH perf/core v11 13/23] perf buildid-cache: Scan and import user SDT events to probe cache Masami Hiramatsu
2016-06-15 3:41 ` [PATCH perf/core v11 14/23] perf probe: Accept %sdt and %cached event name Masami Hiramatsu
2016-06-15 3:41 ` [PATCH perf/core v11 15/23] perf-list: Show SDT and pre-cached events Masami Hiramatsu
2016-06-15 3:42 ` [PATCH perf/core v11 16/23] perf-list: Skip SDTs placed in invalid binaries Masami Hiramatsu
2016-06-15 3:42 ` [PATCH perf/core v11 17/23] perf: probe-cache: Add for_each_probe_cache_entry() wrapper Masami Hiramatsu
2016-06-15 3:42 ` [PATCH perf/core v11 18/23] perf probe: Allow wildcard for cached events Masami Hiramatsu
2016-06-15 3:42 ` [PATCH perf/core v11 19/23] perf probe: Search SDT/cached event from all probe caches Masami Hiramatsu
2016-06-15 3:42 ` [PATCH perf/core v11 20/23] perf probe: Support @BUILDID or @FILE suffix for SDT events Masami Hiramatsu
2016-06-15 3:42 ` [PATCH perf/core v11 21/23] perf probe: Support a special SDT probe format Masami Hiramatsu
2016-06-15 3:43 ` [PATCH perf/core v11 22/23] perf build: Add sdt feature detection Masami Hiramatsu
2016-06-15 3:43 ` [PATCH perf/core v11 23/23] perf-test: Add a test case for SDT event Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160615033950.2064.1796.stgit@devbox \
--to=mhiramat@kernel.org \
--cc=acme@kernel.org \
--cc=ananth@linux.vnet.ibm.com \
--cc=brendan.d.gregg@gmail.com \
--cc=hemant@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox