From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753400AbcFOIHB (ORCPT ); Wed, 15 Jun 2016 04:07:01 -0400 Received: from mail-wm0-f54.google.com ([74.125.82.54]:35392 "EHLO mail-wm0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750841AbcFOIG6 (ORCPT ); Wed, 15 Jun 2016 04:06:58 -0400 Date: Wed, 15 Jun 2016 10:06:54 +0200 From: Ingo Molnar To: Andy Shevchenko Cc: Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, "Dan O'Donovan" , linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 1/1] x86/platform/intel-mid: Enable GPIO expanders on Edison Message-ID: <20160615080653.GA16023@gmail.com> References: <1465945918-27104-1-git-send-email-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1465945918-27104-1-git-send-email-andriy.shevchenko@linux.intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Andy Shevchenko wrote: > +static const struct devs_id pcal9555a_1_dev_id __initconst = { > + .name = "pcal9555a-1", > + .type = SFI_DEV_TYPE_I2C, > + .delay = 1, > + .get_platform_data = &pcal9555a_platform_data, > +}; > + > +static const struct devs_id pcal9555a_2_dev_id __initconst = { > + .name = "pcal9555a-2", > + .type = SFI_DEV_TYPE_I2C, > + .delay = 1, > + .get_platform_data = &pcal9555a_platform_data, > +}; > + > +static const struct devs_id pcal9555a_3_dev_id __initconst = { > + .name = "pcal9555a-3", > + .type = SFI_DEV_TYPE_I2C, > + .delay = 1, > + .get_platform_data = &pcal9555a_platform_data, > +}; > + > +static const struct devs_id pcal9555a_4_dev_id __initconst = { > + .name = "pcal9555a-4", > + .type = SFI_DEV_TYPE_I2C, > + .delay = 1, > + .get_platform_data = &pcal9555a_platform_data, > +}; I have the same complaint as yesterday. Going forward could we please get nice structure initializers in all future patches? :) Thanks, Ingo