From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753555AbcFOL4L (ORCPT ); Wed, 15 Jun 2016 07:56:11 -0400 Received: from 8bytes.org ([81.169.241.247]:34898 "EHLO theia.8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753113AbcFOL4I (ORCPT ); Wed, 15 Jun 2016 07:56:08 -0400 Date: Wed, 15 Jun 2016 13:54:07 +0200 From: "joro@8bytes.org" To: "Vesely, Jan" Cc: "linux-kernel@vger.kernel.org" , "iommu@lists.linux-foundation.org" Subject: Re: [PATCH 2/2] iommu/amd: Destroy api_lock mutex when freeing domain Message-ID: <20160615115406.GF26566@8bytes.org> References: <1463854264-26445-1-git-send-email-jan.vesely@rutgers.edu> <1463854264-26445-2-git-send-email-jan.vesely@rutgers.edu> <1465487321.7114.0.camel@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1465487321.7114.0.camel@amd.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 09, 2016 at 03:48:44PM +0000, Vesely, Jan wrote: > On Sat, 2016-05-21 at 14:11 -0400, Jan Vesely wrote: > > From: Jan Vesely > > > > Signed-off-by: Jan Vesely > > --- > >  drivers/iommu/amd_iommu.c | 1 + > >  1 file changed, 1 insertion(+) > > > > diff --git a/drivers/iommu/amd_iommu.c b/drivers/iommu/amd_iommu.c > > index 17c76f2..4ff5e40 100644 > > --- a/drivers/iommu/amd_iommu.c > > +++ b/drivers/iommu/amd_iommu.c > > @@ -3016,6 +3016,7 @@ static void protection_domain_free(struct > > protection_domain *domain) > >   > >   del_domain_from_list(domain); > >   > > + mutex_destroy(&domain->api_lock); > >   if (domain->id) > >   domain_id_free(domain->id); > >   > > ping Your patches lack commit messages, please add a more detailed description of what you are fixing and why. Please also add 'Fixes:' tags when resubmitting. The changes itself look good to me. Joerg