From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753665AbcFOMpn (ORCPT ); Wed, 15 Jun 2016 08:45:43 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:15319 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753313AbcFOMpk (ORCPT ); Wed, 15 Jun 2016 08:45:40 -0400 X-IBM-Helo: d03dlp03.boulder.ibm.com X-IBM-MailFrom: paulmck@linux.vnet.ibm.com X-IBM-RcptTo: linux-kernel@vger.kernel.org Date: Wed, 15 Jun 2016 05:45:32 -0700 From: "Paul E. McKenney" To: Richard Weinberger Cc: kbuild test robot , kbuild-all@01.org, linux-kernel@vger.kernel.org, jdike@addtoit.com, user-mode-linux-devel@lists.sourceforge.net Subject: Re: [rcu:rcu/next 25/36] include/linux/irqflags.h:79:3: error: implicit declaration of function 'arch_irqs_disabled_flags' Reply-To: paulmck@linux.vnet.ibm.com References: <201606060200.kVmeQzvA%fengguang.wu@intel.com> <20160614225417.GR3923@linux.vnet.ibm.com> <5760FE41.9060603@nod.at> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5760FE41.9060603@nod.at> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16061512-0016-0000-0000-000003F3A0CE X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16061512-0017-0000-0000-000030382293 Message-Id: <20160615124532.GW3923@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-06-15_07:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000 definitions=main-1606150139 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 15, 2016 at 09:05:37AM +0200, Richard Weinberger wrote: > Paul, > > Am 15.06.2016 um 00:54 schrieb Paul E. McKenney: > > On Mon, Jun 06, 2016 at 02:04:03AM +0800, kbuild test robot wrote: > >> tree: https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git rcu/next > >> head: 13ee0de9cd2444b57ce30c4f1607b49b90aa0c38 > >> commit: f251ac814fc5787765009e60d54a2bd4277350c8 [25/36] rcu: Make call_rcu_tasks() tolerate first call with irqs disabled > >> config: um-allmodconfig (attached as .config) > >> compiler: gcc-6 (Debian 6.1.1-1) 6.1.1 20160430 > >> reproduce: > >> git checkout f251ac814fc5787765009e60d54a2bd4277350c8 > >> # save the attached .config to linux build tree > >> make ARCH=um > > > > My kneejerk reaction would be to make CONFIG_TASKS_RCU depend on > > !UML or something similar. > > > > Another approach would be create a arch_irqs_disabled_flags() for UML. > > > > Any preferences? > > Patches for arch_irqs_disabled_flags() support are already on LKML: > https://lkml.org/lkml/2016/6/12/162 > > My plan was to merge them in the v4.8 merge window. > So having CONFIG_TASKS_RCU depend on !UML for now should be fine. > We can remove the dependency in v4.8 again. Sounds very good, thank you! Thanx, Paul