From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932952AbcFOOcG (ORCPT <rfc822;w@1wt.eu>);
	Wed, 15 Jun 2016 10:32:06 -0400
Received: from relay5-d.mail.gandi.net ([217.70.183.197]:52355 "EHLO
	relay5-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753293AbcFOOcD (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 15 Jun 2016 10:32:03 -0400
X-Originating-IP: 50.39.163.18
Date: Wed, 15 Jun 2016 07:31:52 -0700
From: Josh Triplett <josh@joshtriplett.org>
To: Riku Voipio <riku.voipio@linaro.org>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>,
        Vineet Gupta <vgupta@synopsys.com>, Michal Marek <mmarek@suse.cz>
Subject: Re: [PATCH] scripts/bloat-o-meter: fix percent on <1% changes
Message-ID: <20160615143152.GA10418@x>
References: <1465980311-23814-1-git-send-email-riku.voipio@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1465980311-23814-1-git-send-email-riku.voipio@linaro.org>
User-Agent: Mutt/1.6.0 (2016-04-01)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Jun 15, 2016 at 11:45:11AM +0300, Riku Voipio wrote:
> Python divisions are integer divisions unless at least one parameter
> is a float. The current bloat-o-meter fails to print sub-percentage
> changes:
> 
> Total: Before=10515408, After=10604060, chg 0.000000%
> 
> Force float division by using one float and pretty the print to
> two significant decimals:
> 
> Total: Before=10515408, After=10604060, chg +0.84%
> 
> Signed-off-by: Riku Voipio <riku.voipio@linaro.org>
> Cc: Vineet Gupta <vgupta@synopsys.com>
> Cc: Josh Triplett <josh@joshtriplett.org>
> Cc: Michal Marek <mmarek@suse.cz>

Good idea.
Reviewed-by: Josh Triplett <josh@joshtriplett.org>

> ---
>  scripts/bloat-o-meter | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/scripts/bloat-o-meter b/scripts/bloat-o-meter
> index 0254f3b..19f5adf 100755
> --- a/scripts/bloat-o-meter
> +++ b/scripts/bloat-o-meter
> @@ -67,5 +67,5 @@ print("%-40s %7s %7s %+7s" % ("function", "old", "new", "delta"))
>  for d, n in delta:
>      if d: print("%-40s %7s %7s %+7d" % (n, old.get(n,"-"), new.get(n,"-"), d))
>  
> -print("Total: Before=%d, After=%d, chg %f%%" % \
> -    (otot, ntot, (ntot - otot)*100/otot))
> +print("Total: Before=%d, After=%d, chg %+.2f%%" % \
> +    (otot, ntot, (ntot - otot)*100.0/otot))
> -- 
> 2.1.4
>