From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933092AbcFOOmD (ORCPT ); Wed, 15 Jun 2016 10:42:03 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:34921 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932850AbcFOOmB (ORCPT ); Wed, 15 Jun 2016 10:42:01 -0400 X-IBM-Helo: d06dlp02.portsmouth.uk.ibm.com X-IBM-MailFrom: brueckner@linux.vnet.ibm.com X-IBM-RcptTo: linux-crypto@vger.kernel.org;linux-kernel@vger.kernel.org Date: Wed, 15 Jun 2016 16:41:53 +0200 From: Hendrik Brueckner To: Andreas Ziegler Cc: Hendrik Brueckner , Martin Schwidefsky , Herbert Xu , "David S. Miller" , linux-crypto@vger.kernel.org, linux-kernel Subject: Re: select on non-existing Kconfig option CRC32C References: <5761275B.4010508@fau.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5761275B.4010508@fau.de> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16061514-0008-0000-0000-0000028C155B X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16061514-0009-0000-0000-000018C367C5 Message-Id: <20160615144153.GB4700@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-06-15_09:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000 definitions=main-1606150158 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Andreas, On Wed, Jun 15, 2016 at 12:00:59PM +0200, Andreas Ziegler wrote: > > your patch "s390/crc32-vx: add crypto API module for optimized CRC-32 > algorithms" showed up in linux-next today (next-20160615) as commit 364148e0b195. > > The patch defines the Kconfig option CRYPTO_CRC32_S390 which 'select's CRC32C. > However, this should probably have been CRYPTO_CRC32C, as CRC32C does not exist. Thanks for informing me. Actually, the crc32-vx driver requires the __crc32c_le() function which is available by selecting CONFIG_CRC32. There is no need for CRYPTO_CRC32C. So this can be safely removed. > Should I prepare a trivial patch to fix this up or would you like to do that on > your side? Martin have already corrected the patch. Thanks and kind regards, Hendrik