The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Michal Marek <mmarek@suse.com>
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org,
	dri-devel@lists.freedesktop.org, Arnd Bergmann <arnd@arndb.de>
Subject: [PATCH v2 05/11] Kbuild: don't add obj tree in additional includes
Date: Wed, 15 Jun 2016 17:45:47 +0200	[thread overview]
Message-ID: <20160615154553.3177021-6-arnd@arndb.de> (raw)
In-Reply-To: <20160615154553.3177021-1-arnd@arndb.de>

When building with separate object directories and driver specific
Makefiles that add additional header include paths, Kbuild adjusts
the gcc flags so that we include both the directory in the source
tree and in the object tree.

However, due to another bug I fixed earlier, this did not actually
include the correct directory in the object tree, so we know that
we only really need the source tree here. Also, including the
object tree sometimes causes warnings about nonexisting directories
when the include path only exists in the source.

This changes the logic to only emit the -I argument for the srctree,
not for objects. We still need both $(srctree)/$(src) and $(obj)
though, so I'm adding them manually.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 scripts/Kbuild.include | 2 +-
 scripts/Makefile.lib   | 7 ++++---
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/scripts/Kbuild.include b/scripts/Kbuild.include
index f8b45eb47ed3..15b196fc2f49 100644
--- a/scripts/Kbuild.include
+++ b/scripts/Kbuild.include
@@ -202,7 +202,7 @@ hdr-inst := -f $(srctree)/scripts/Makefile.headersinst obj
 # Prefix -I with $(srctree) if it is not an absolute path.
 # skip if -I has no parameter
 addtree = $(if $(patsubst -I%,%,$(1)), \
-$(if $(filter-out -I/% -I../%,$(1)),$(patsubst -I%,-I$(srctree)/%,$(1))) $(1))
+$(if $(filter-out -I/% -I./% -I../%,$(1)),$(patsubst -I%,-I$(srctree)/%,$(1)),$(1)))
 
 # Find all -I options and call addtree
 flags = $(foreach o,$($(1)),$(if $(filter -I%,$(o)),$(call addtree,$(o)),$(o)))
diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
index 76494e15417b..0a07f9014944 100644
--- a/scripts/Makefile.lib
+++ b/scripts/Makefile.lib
@@ -155,9 +155,10 @@ else
 # $(call addtree,-I$(obj)) locates .h files in srctree, from generated .c files
 #   and locates generated .h files
 # FIXME: Replace both with specific CFLAGS* statements in the makefiles
-__c_flags	= $(call addtree,-I$(obj)) $(call flags,_c_flags)
-__a_flags	=                          $(call flags,_a_flags)
-__cpp_flags     =                          $(call flags,_cpp_flags)
+__c_flags	= $(if $(obj),-I$(srctree)/$(src) -I$(obj)) \
+		  $(call flags,_c_flags)
+__a_flags	= $(call flags,_a_flags)
+__cpp_flags     = $(call flags,_cpp_flags)
 endif
 
 c_flags        = -Wp,-MD,$(depfile) $(NOSTDINC_FLAGS) $(LINUXINCLUDE)     \
-- 
2.9.0

  parent reply	other threads:[~2016-06-15 15:46 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-15 15:45 [PATCH v2 00/11] Kbuild: fix -Wmissing-include-path warnings Arnd Bergmann
2016-06-15 15:45 ` [PATCH v2 01/11] Kbuild: don't add ../../ to include path Arnd Bergmann
2016-06-15 15:45 ` [PATCH v2 02/11] Kbuild: avoid duplicate " Arnd Bergmann
2016-06-15 15:45 ` [PATCH v2 03/11] Kbuild: always prefix objtree in LINUXINCLUDE Arnd Bergmann
2016-06-15 15:45 ` [PATCH v2 04/11] Kbuild: arch: look for generated headers in obtree Arnd Bergmann
2016-06-15 15:45 ` Arnd Bergmann [this message]
2016-07-18 20:14   ` [PATCH v2 05/11] Kbuild: don't add obj tree in additional includes Michal Marek
2016-07-19  8:31     ` Arnd Bergmann
2016-07-19 14:33       ` Kalle Valo
2016-07-19 15:38         ` Arnd Bergmann
2016-07-19 18:07           ` Kalle Valo
2016-06-15 15:45 ` [PATCH v2 06/11] ARM: don't include removed directories Arnd Bergmann
2016-06-15 15:45 ` [PATCH v2 07/11] ARM: hide mach-*/ include for ARM_SINGLE_ARMV7M Arnd Bergmann
2016-06-15 15:45 ` [PATCH v2 08/11] drm: amd: remove broken include path Arnd Bergmann
2016-06-15 15:45 ` [PATCH v2 09/11] net: skfb: remove obsolete -I cflag Arnd Bergmann
2016-06-16  5:06   ` David Miller
2016-06-15 15:45 ` [PATCH v2 10/11] rtlwifi: don't add include path for rtl8188ee Arnd Bergmann
2016-06-15 15:45 ` [PATCH v2 11/11] [EXPERIMENTAL] Kbuild: enable -Wmissing-include-dirs by default Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160615154553.3177021-6-arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mmarek@suse.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox