From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Chen-Yu Tsai <wens@csie.org>
Cc: "Bernhard Nortmann" <bernhard.nortmann@web.de>,
"Julian Calaby" <julian.calaby@gmail.com>,
罗翼 <luoyi.ly@gmail.com>, "Rob Herring" <robh+dt@kernel.org>,
"Pawel Moll" <pawel.moll@arm.com>,
"Mark Rutland" <mark.rutland@arm.com>,
"Ian Campbell" <ijc+devicetree@hellion.org.uk>,
"Kumar Gala" <galak@codeaurora.org>,
"Russell King" <linux@arm.linux.org.uk>,
devicetree <devicetree@vger.kernel.org>,
"Mailing List, Arm" <linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-sunxi <linux-sunxi@googlegroups.com>
Subject: Re: [linux-sunxi] [PATCH] [V2] ARM: dts: sun7i: Add dts file for Bananapi M1 Plus board
Date: Wed, 15 Jun 2016 22:52:23 +0200 [thread overview]
Message-ID: <20160615205223.GC5144@lukather> (raw)
In-Reply-To: <CAGb2v64PYU9H7Ag45ogwtjJAO87D6saTFv5-4P_E7d1xobQXXA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2006 bytes --]
Hi Chen-Yu,
On Mon, Jun 13, 2016 at 11:01:53AM +0800, Chen-Yu Tsai wrote:
> On Fri, Jun 10, 2016 at 5:38 PM, Maxime Ripard
> <maxime.ripard@free-electrons.com> wrote:
> > On Thu, Jun 02, 2016 at 11:15:55AM +0200, Bernhard Nortmann wrote:
> >> Am 02.06.2016 um 10:16 schrieb Maxime Ripard:
> >> >[...]
> >> >Yes, everything that is shared with the banana-pro (which, judging
> >> >from Bernhard, is pretty much everything but a GPIO) should be merged
> >> >in the banapro DT.
> >> >
> >> >Maxime
> >> >
> >>
> >> Don't take my word for granted, as I do not own this hardware or know it
> >> particularly well. There is no doubt that "BPi-M1+" and "Banana Pro" are
> >> very similar, but if in doubt the information form the wiki should be
> >> verified.
> >
> > Hmmmm, ok. Chen-Yu, any input on this? You know the banana-pis much
> > more than I do.
>
> I did a comparison of the "Banana Pro" vs the "BPi-M1+".
>
> The differences are similar to what we have with any other development
> board, say the Cubietruck:
>
> - A different WiFi chip is used, and the BT part is not hooked up.
> - Different GPIOs for external power regulator/switches
> - Different GPIOs for LEDs
> - Different peripherals exposed on the headers.
>
> IMO There's no need to merge or have a common .dtsi for the two boards.
Ok.
> They (and all the other development boards) look similar because
> everyone is following the basic set by Allwinner's reference design,
> like which MMC controller and pins are used for SD/MMC, which ones
> are used for SDIO-based WiFi, and so on.
>
> I did a version completely from scratch using just the schematics:
>
> https://github.com/wens/linux/commits/bpi-m1-plus
So, what do you mean by that? Do you have some comments on that patch,
or should I merge it, and you'll post your additions on top of it?
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-06-15 20:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-02 2:36 [PATCH] [V2] ARM: dts: sun7i: Add dts file for Bananapi M1 Plus board luoyi.ly
2016-06-02 2:55 ` [linux-sunxi] " Julian Calaby
2016-06-02 8:16 ` Maxime Ripard
2016-06-02 9:15 ` Bernhard Nortmann
2016-06-03 6:13 ` luoyi.ly
2016-06-10 9:39 ` Maxime Ripard
2016-06-10 9:38 ` Maxime Ripard
2016-06-13 3:01 ` Chen-Yu Tsai
2016-06-15 20:52 ` Maxime Ripard [this message]
2016-06-16 3:05 ` Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160615205223.GC5144@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=bernhard.nortmann@web.de \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=julian.calaby@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=linux@arm.linux.org.uk \
--cc=luoyi.ly@gmail.com \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox