From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933144AbcFOWQw (ORCPT ); Wed, 15 Jun 2016 18:16:52 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:55065 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753129AbcFOWQu (ORCPT ); Wed, 15 Jun 2016 18:16:50 -0400 X-IBM-Helo: d01dlp01.pok.ibm.com X-IBM-MailFrom: paulmck@linux.vnet.ibm.com X-IBM-RcptTo: linux-kernel@vger.kernel.org Date: Wed, 15 Jun 2016 15:16:45 -0700 From: "Paul E. McKenney" To: Peter Zijlstra Cc: linux-kernel@vger.kernel.org, mingo@kernel.org, jiangshanlai@gmail.com, dipankar@in.ibm.com, akpm@linux-foundation.org, mathieu.desnoyers@efficios.com, josh@joshtriplett.org, tglx@linutronix.de, rostedt@goodmis.org, dhowells@redhat.com, edumazet@google.com, dvhart@linux.intel.com, fweisbec@gmail.com, oleg@redhat.com, bobby.prani@gmail.com Subject: Re: [PATCH tip/core/rcu 04/12] rcu: Move expedited code from tree.c to tree_exp.h Reply-To: paulmck@linux.vnet.ibm.com References: <20160615214550.GA4931@linux.vnet.ibm.com> <1466027173-5501-4-git-send-email-paulmck@linux.vnet.ibm.com> <20160615220539.GA30921@twins.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160615220539.GA30921@twins.programming.kicks-ass.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16061522-0040-0000-0000-000000934D60 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16061522-0041-0000-0000-0000046D2B75 Message-Id: <20160615221645.GZ3923@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-06-15_13:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000 definitions=main-1606150235 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 16, 2016 at 12:05:39AM +0200, Peter Zijlstra wrote: > On Wed, Jun 15, 2016 at 02:46:05PM -0700, Paul E. McKenney wrote: > > People have been having some difficulty finding their way around the > > RCU code. This commit therefore pulls some of the expedited grace-period > > code from tree.c to a new tree_exp.h file. This commit is strictly code > > movement, with the exception of a forward declaration that was added > > for the sync_sched_exp_online_cleanup() function. > > > > A subsequent commit will move the remaining expedited grace-period code > > from tree_plugin.h to tree_exp.h. > > Part of the problem for me is always the fact that its so weirdly > divided over these files. Now you're making that worse. How is this > helping? The expedited stuff is now in one place rather than being split across two different files. Thanx, Paul